[CI] Add Python Script for Computing Projects/Runtimes to Test #132634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Mar 23, 2025
This patch adds a python script, compute_projects, and associated unit tests for computing the projects and runtimes that need to be tested in premerge. Rewriting in Python opens up a couple new improvements/opportunities: 1. I personally find python to be much easier to work with than shell scripts for tasks like this. Particularly it becomes a lot easier to work with paths with proper array support. 2. Unit testing becomes easier which makes it a lot easier to reason about behavior changes, especially in review. 3. Most of the configuration is now setup in some dictionaries, which makes changes much easier to apply for most of the common changes. This preserves the behavior of the existing premerge scripts as much as possible. Pull Request: llvm#132634
Created using spr 1.3.4
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Mar 23, 2025
This patch adds a python script, compute_projects, and associated unit tests for computing the projects and runtimes that need to be tested in premerge. Rewriting in Python opens up a couple new improvements/opportunities: 1. I personally find python to be much easier to work with than shell scripts for tasks like this. Particularly it becomes a lot easier to work with paths with proper array support. 2. Unit testing becomes easier which makes it a lot easier to reason about behavior changes, especially in review. 3. Most of the configuration is now setup in some dictionaries, which makes changes much easier to apply for most of the common changes. This preserves the behavior of the existing premerge scripts as much as possible. Pull Request: llvm#132634
Created using spr 1.3.4
boomanaiden154
requested review from
tstellar,
ldionne,
lnihlen,
Keenuts,
Endilll and
joker-eph
|
✅ With the latest revision this PR passed the Python code formatter. |
lnihlen
reviewed
Mar 23, 2025
Keenuts
reviewed
Mar 24, 2025
joker-eph
reviewed
Mar 24, 2025
| import platform | ||
| import sys | ||
|
|
||
| PROJECT_DEPENDENCIES = { |
There was a problem hiding this comment.
Can you add a comment about the content of this? What is this conveying and when you a project include others in its list?
Reading the usage of this, it seems like it is handling transitive dependencies for example, so I assume we should only list direct dependencies?
Also some dependencies are optional (depending on the CMake configuration), so worth giving some idea of what is the intent and the effect (to know when / whether to be conservative or how to exercise judgement).
There was a problem hiding this comment.
I added a comment.
Yes, it handles transitive dependencies automatically (and I made sure to note that in the comment).
The dependencies should match what is required for the configuration int the premerge CI (also mentioned that in the comment).
| "polly": {"llvm"}, | ||
| } | ||
|
|
||
| DEPENDENTS_TO_TEST = { |
There was a problem hiding this comment.
(same as above somehow)
There was a problem hiding this comment.
Added a comment here as well on what exactly it does and the intention surrounding it.
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Mar 24, 2025
This patch adds a python script, compute_projects, and associated unit tests for computing the projects and runtimes that need to be tested in premerge. Rewriting in Python opens up a couple new improvements/opportunities: 1. I personally find python to be much easier to work with than shell scripts for tasks like this. Particularly it becomes a lot easier to work with paths with proper array support. 2. Unit testing becomes easier which makes it a lot easier to reason about behavior changes, especially in review. 3. Most of the configuration is now setup in some dictionaries, which makes changes much easier to apply for most of the common changes. This preserves the behavior of the existing premerge scripts as much as possible. Pull Request: llvm#132634
Endilll
reviewed
Mar 24, 2025
Keenuts
approved these changes
Mar 25, 2025
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Mar 26, 2025
This patch adds a python script, compute_projects, and associated unit tests for computing the projects and runtimes that need to be tested in premerge. Rewriting in Python opens up a couple new improvements/opportunities: 1. I personally find python to be much easier to work with than shell scripts for tasks like this. Particularly it becomes a lot easier to work with paths with proper array support. 2. Unit testing becomes easier which makes it a lot easier to reason about behavior changes, especially in review. 3. Most of the configuration is now setup in some dictionaries, which makes changes much easier to apply for most of the common changes. This preserves the behavior of the existing premerge scripts as much as possible. Pull Request: llvm#132634
boomanaiden154
deleted the
users/boomanaiden154/ci-add-python-script-for-computing-projectsruntimes-to-test
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Mar 26, 2025
…Test This patch adds a python script, compute_projects, and associated unit tests for computing the projects and runtimes that need to be tested in premerge. Rewriting in Python opens up a couple new improvements/opportunities: 1. I personally find python to be much easier to work with than shell scripts for tasks like this. Particularly it becomes a lot easier to work with paths with proper array support. 2. Unit testing becomes easier which makes it a lot easier to reason about behavior changes, especially in review. 3. Most of the configuration is now setup in some dictionaries, which makes changes much easier to apply for most of the common changes. This preserves the behavior of the existing premerge scripts as much as possible. Reviewers: ldionne, lnihlen, Endilll, tstellar, Keenuts Reviewed By: Keenuts Pull Request: llvm/llvm-project#132634
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a python script, compute_projects, and associated unit
tests for computing the projects and runtimes that need to be tested in
premerge. Rewriting in Python opens up a couple new
improvements/opportunities:
scripts for tasks like this. Particularly it becomes a lot easier to
work with paths with proper array support.
about behavior changes, especially in review.
makes changes much easier to apply for most of the common changes.
This preserves the behavior of the existing premerge scripts as much as
possible.