llvm-reduce: Fix asserting on TargetExtTypes that do not support zeroinit #132733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arsenm
requested review from
aeubanks,
jayfoad,
jcranmer-intel,
nhaehnle and
regehr
This stack of pull requests is managed by Graphite. Learn more about stacking. |
arsenm
force-pushed
the
users/arsenm/llvm-reduce/fix-assert-target-ext-type-getDefaultValue
branch
from
caedfd8 to
7a64f7f
Compare
aeubanks
approved these changes
Mar 24, 2025
arsenm
force-pushed
the
users/arsenm/llvm-reduce/fix-assert-target-ext-type-getDefaultValue
branch
from
7a64f7f to
42c74dd
Compare
arsenm
force-pushed
the
users/arsenm/llvm-reduce/fix-assert-operands-to-zero-target-ext-type
branch
from
2eab5bb to
633b42c
Compare
Base automatically changed from
users/arsenm/llvm-reduce/fix-assert-operands-to-zero-target-ext-type
to
main
March 25, 2025 04:38
…init So far I've been unsuccessful in finding an example where the used constant value is directly observed in the output. This avoids an assert in an intermediate step of value replacement.
arsenm
force-pushed
the
users/arsenm/llvm-reduce/fix-assert-target-ext-type-getDefaultValue
branch
from
42c74dd to
e6e0295
Compare
arsenm
deleted the
users/arsenm/llvm-reduce/fix-assert-target-ext-type-getDefaultValue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far I've been unsuccessful in finding an example where the used constant
value is directly observed in the output. This avoids an assert in an intermediate
step of value replacement.