GCStrategy: Use Twine properly for error message #132760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-llvm-transforms @llvm/pr-subscribers-llvm-ir Author: Matt Arsenault (arsenm) ChangesAvoid unnecessary std::string temporaries. Full diff: https://github.com/llvm/llvm-project/pull/132760.diff 1 Files Affected:
diff --git a/llvm/lib/IR/GCStrategy.cpp b/llvm/lib/IR/GCStrategy.cpp
index c3e35bd58d13e..67f363d26b25f 100644
--- a/llvm/lib/IR/GCStrategy.cpp
+++ b/llvm/lib/IR/GCStrategy.cpp
@@ -41,10 +41,9 @@ std::unique_ptr<GCStrategy> llvm::getGCStrategy(const StringRef Name) {
// be the builtin GCs if nothing else. The most likely scenario here is
// that we got here without running the initializers used by the Registry
// itself and it's registration mechanism.
- const std::string error =
- std::string("unsupported GC: ") + Name.str() +
- " (did you remember to link and initialize the library?)";
- report_fatal_error(Twine(error));
+ report_fatal_error(
+ "unsupported GC: " + Name +
+ " (did you remember to link and initialize the library?)");
} else
- report_fatal_error(Twine(std::string("unsupported GC: ") + Name.str()));
+ report_fatal_error(Twine("unsupported GC: ") + Name);
}
|
|
ping |
Avoid unnecessary std::string temporaries.
arsenm
force-pushed
the
users/arsenm/gcstrategy/use-twine-for-error-message
branch
from
0cf71d7 to
9820044
Compare
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/12287 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary std::string temporaries.