Skip to content

Implement areInlineCompatible for SystemZ using feature bitset #132976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions llvm/lib/Target/SystemZ/SystemZTargetTransformInfo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,20 @@ bool SystemZTTIImpl::isLSRCostLess(const TargetTransformInfo::LSRCost &C1,
C2.ScaleCost, C2.SetupCost);
}

bool SystemZTTIImpl::areInlineCompatible(const Function *Caller,
const Function *Callee) const {
const TargetMachine &TM = getTLI()->getTargetMachine();

const FeatureBitset &CallerBits =
TM.getSubtargetImpl(*Caller)->getFeatureBits();
const FeatureBitset &CalleeBits =
TM.getSubtargetImpl(*Callee)->getFeatureBits();

// Support only equal feature bitsets. Restriction should be relaxed in the
// future to allow inlining when callee's bits are subset of the caller's.
return CallerBits == CalleeBits;
}

unsigned SystemZTTIImpl::getNumberOfRegisters(unsigned ClassID) const {
bool Vector = (ClassID == 1);
if (!Vector)
Expand Down
4 changes: 4 additions & 0 deletions llvm/lib/Target/SystemZ/SystemZTargetTransformInfo.h
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ class SystemZTTIImpl : public BasicTTIImplBase<SystemZTTIImpl> {

bool isLSRCostLess(const TargetTransformInfo::LSRCost &C1,
const TargetTransformInfo::LSRCost &C2);

bool areInlineCompatible(const Function *Caller,
const Function *Callee) const;

/// @}

/// \name Vector TTI Implementations
Expand Down
42 changes: 42 additions & 0 deletions llvm/test/Transforms/Inline/SystemZ/inline-target-attr.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
; RUN: opt < %s -mtriple=s390x-linux-gnu -S -passes=inline | FileCheck %s
; RUN: opt < %s -mtriple=s390x-linux-gnu -S -passes='cgscc(inline)' | FileCheck %s
; Check that we only inline when we have equal target attributes.

define i32 @foo() #0 {
entry:
%call = call i32 (...) @baz()
ret i32 %call
; CHECK-LABEL: foo
; CHECK: call i32 (...) @baz()
}

declare i32 @baz(...) #0

define i32 @bar() #1 {
entry:
%call = call i32 @foo()
ret i32 %call
; CHECK-LABEL: bar
; CHECK: call i32 @foo()
}

define i32 @qux() #0 {
entry:
%call = call i32 @foo()
ret i32 %call
; CHECK-LABEL: qux
; CHECK: call i32 (...) @baz()
}

define i32 @quux() #2 {
entry:
%call = call i32 @bar()
ret i32 %call
; CHECK-LABEL: quux
; CHECK: call i32 @bar()
}


attributes #0 = { "target-cpu"="generic" "target-features"="+guarded-storage" }
attributes #1 = { "target-cpu"="generic" "target-features"="+guarded-storage,+enhanced-sort" }
attributes #2 = { "target-cpu"="generic" "target-features"="+concurrent-functions" }
2 changes: 2 additions & 0 deletions llvm/test/Transforms/Inline/SystemZ/lit.local.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
if not "SystemZ" in config.root.targets:
config.unsupported = True
Loading