clangd: Add a build option to disable building dexp #133124

ycongal-smile · 2025-03-26T16:55:21Z

Building dexp on Debian 11 currently causes intermittent failure0 1.

Adding the CLANGD_BUILD_DEXP option to disable dexp from the build allows Debian 11 users to build clang (albeit without the dexp tool).

This option is set to "Build Dexp" by default so, no change is expected without manual setting.

github-actions · 2025-03-26T16:55:41Z

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

llvmbot · 2025-03-26T16:56:16Z

@llvm/pr-subscribers-clangd

Author: Yoann Congal (ycongal-smile)

Changes

Building dexp on Debian 11 currently causes intermittent failure0 1.

Adding the CLANGD_BUILD_DEXP option to disable dexp from the build allows Debian 11 users to build clang (albeit without the dexp tool).

This option is set to "Build Dexp" by default so, no change is expected without manual setting.

Full diff: https://github.com/llvm/llvm-project/pull/133124.diff

4 Files Affected:

(modified) clang-tools-extra/clangd/CMakeLists.txt (+5-1)
(modified) clang-tools-extra/clangd/test/CMakeLists.txt (+5-2)
(modified) clang-tools-extra/clangd/test/lit.site.cfg.py.in (+1)
(modified) llvm/utils/gn/secondary/clang-tools-extra/clangd/test/BUILD.gn (+5-1)

diff --git a/clang-tools-extra/clangd/CMakeLists.txt b/clang-tools-extra/clangd/CMakeLists.txt
index 6f10afe4a5625..279515d635d38 100644
--- a/clang-tools-extra/clangd/CMakeLists.txt
+++ b/clang-tools-extra/clangd/CMakeLists.txt
@@ -220,4 +220,8 @@ option(CLANGD_ENABLE_REMOTE "Use gRPC library to enable remote index support for
 set(GRPC_INSTALL_PATH "" CACHE PATH "Path to gRPC library manual installation.")
 
 add_subdirectory(index/remote)
-add_subdirectory(index/dex/dexp)
+
+option(CLANGD_BUILD_DEXP "Build the dexp tool as part of Clangd" ON)
+if(CLANGD_BUILD_DEXP)
+  add_subdirectory(index/dex/dexp)
+endif()
diff --git a/clang-tools-extra/clangd/test/CMakeLists.txt b/clang-tools-extra/clangd/test/CMakeLists.txt
index b51f461a49866..42fc3506641f2 100644
--- a/clang-tools-extra/clangd/test/CMakeLists.txt
+++ b/clang-tools-extra/clangd/test/CMakeLists.txt
@@ -3,8 +3,6 @@ set(CLANGD_TEST_DEPS
   ClangdTests
   clangd-indexer
   split-file
-  # No tests for it, but we should still make sure they build.
-  dexp
   )
 
 if(CLANGD_BUILD_XPC)
@@ -12,6 +10,11 @@ if(CLANGD_BUILD_XPC)
   list(APPEND CLANGD_TEST_DEPS ClangdXpcUnitTests)
 endif()
 
+if(CLANGD_BUILD_DEXP)
+  # No tests for it, but we should still make sure they build.
+  list(APPEND CLANGD_TEST_DEPS dexp)
+endif()
+
 if(CLANGD_ENABLE_REMOTE)
   list(APPEND CLANGD_TEST_DEPS clangd-index-server clangd-index-server-monitor)
 endif()
diff --git a/clang-tools-extra/clangd/test/lit.site.cfg.py.in b/clang-tools-extra/clangd/test/lit.site.cfg.py.in
index 1fe7c8d0f3244..a0bb3561e19ee 100644
--- a/clang-tools-extra/clangd/test/lit.site.cfg.py.in
+++ b/clang-tools-extra/clangd/test/lit.site.cfg.py.in
@@ -15,6 +15,7 @@ config.llvm_shlib_dir = "@SHLIBDIR@"
 config.clangd_source_dir = "@CMAKE_CURRENT_SOURCE_DIR@/.."
 config.clangd_binary_dir = "@CMAKE_CURRENT_BINARY_DIR@/.."
 config.clangd_build_xpc = @CLANGD_BUILD_XPC@
+config.clangd_build_dexp = @CLANGD_BUILD_DEXP@
 config.clangd_enable_remote = @CLANGD_ENABLE_REMOTE@
 config.clangd_tidy_checks = @CLANGD_TIDY_CHECKS@
 config.have_zlib = @LLVM_ENABLE_ZLIB@
diff --git a/llvm/utils/gn/secondary/clang-tools-extra/clangd/test/BUILD.gn b/llvm/utils/gn/secondary/clang-tools-extra/clangd/test/BUILD.gn
index 9d42409f1973f..8bfcb1282f0e5 100644
--- a/llvm/utils/gn/secondary/clang-tools-extra/clangd/test/BUILD.gn
+++ b/llvm/utils/gn/secondary/clang-tools-extra/clangd/test/BUILD.gn
@@ -77,7 +77,6 @@ group("test") {
   deps = [
     ":lit_site_cfg",
     ":lit_unit_site_cfg",
-    "//clang-tools-extra/clangd/index/dex/dexp",
     "//clang-tools-extra/clangd/indexer:clangd-indexer",
     "//clang-tools-extra/clangd/tool:clangd",
     "//clang-tools-extra/clangd/unittests:ClangdTests",
@@ -92,6 +91,11 @@ group("test") {
       "//clang-tools-extra/clangd/xpc/test-client:clangd-xpc-test-client",
     ]
   }
+  if (clangd_build_dexp) {
+    deps += [
+      "//clang-tools-extra/clangd/index/dex/dexp",
+    ]
+  }
   testonly = true
 }

llvmbot · 2025-03-26T16:56:17Z

@llvm/pr-subscribers-clang-tools-extra

Author: Yoann Congal (ycongal-smile)

Changes

Building dexp on Debian 11 currently causes intermittent failure0 1.

Adding the CLANGD_BUILD_DEXP option to disable dexp from the build allows Debian 11 users to build clang (albeit without the dexp tool).

This option is set to "Build Dexp" by default so, no change is expected without manual setting.

Full diff: https://github.com/llvm/llvm-project/pull/133124.diff

4 Files Affected:

(modified) clang-tools-extra/clangd/CMakeLists.txt (+5-1)
(modified) clang-tools-extra/clangd/test/CMakeLists.txt (+5-2)
(modified) clang-tools-extra/clangd/test/lit.site.cfg.py.in (+1)
(modified) llvm/utils/gn/secondary/clang-tools-extra/clangd/test/BUILD.gn (+5-1)

diff --git a/clang-tools-extra/clangd/CMakeLists.txt b/clang-tools-extra/clangd/CMakeLists.txt
index 6f10afe4a5625..279515d635d38 100644
--- a/clang-tools-extra/clangd/CMakeLists.txt
+++ b/clang-tools-extra/clangd/CMakeLists.txt
@@ -220,4 +220,8 @@ option(CLANGD_ENABLE_REMOTE "Use gRPC library to enable remote index support for
 set(GRPC_INSTALL_PATH "" CACHE PATH "Path to gRPC library manual installation.")
 
 add_subdirectory(index/remote)
-add_subdirectory(index/dex/dexp)
+
+option(CLANGD_BUILD_DEXP "Build the dexp tool as part of Clangd" ON)
+if(CLANGD_BUILD_DEXP)
+  add_subdirectory(index/dex/dexp)
+endif()
diff --git a/clang-tools-extra/clangd/test/CMakeLists.txt b/clang-tools-extra/clangd/test/CMakeLists.txt
index b51f461a49866..42fc3506641f2 100644
--- a/clang-tools-extra/clangd/test/CMakeLists.txt
+++ b/clang-tools-extra/clangd/test/CMakeLists.txt
@@ -3,8 +3,6 @@ set(CLANGD_TEST_DEPS
   ClangdTests
   clangd-indexer
   split-file
-  # No tests for it, but we should still make sure they build.
-  dexp
   )
 
 if(CLANGD_BUILD_XPC)
@@ -12,6 +10,11 @@ if(CLANGD_BUILD_XPC)
   list(APPEND CLANGD_TEST_DEPS ClangdXpcUnitTests)
 endif()
 
+if(CLANGD_BUILD_DEXP)
+  # No tests for it, but we should still make sure they build.
+  list(APPEND CLANGD_TEST_DEPS dexp)
+endif()
+
 if(CLANGD_ENABLE_REMOTE)
   list(APPEND CLANGD_TEST_DEPS clangd-index-server clangd-index-server-monitor)
 endif()
diff --git a/clang-tools-extra/clangd/test/lit.site.cfg.py.in b/clang-tools-extra/clangd/test/lit.site.cfg.py.in
index 1fe7c8d0f3244..a0bb3561e19ee 100644
--- a/clang-tools-extra/clangd/test/lit.site.cfg.py.in
+++ b/clang-tools-extra/clangd/test/lit.site.cfg.py.in
@@ -15,6 +15,7 @@ config.llvm_shlib_dir = "@SHLIBDIR@"
 config.clangd_source_dir = "@CMAKE_CURRENT_SOURCE_DIR@/.."
 config.clangd_binary_dir = "@CMAKE_CURRENT_BINARY_DIR@/.."
 config.clangd_build_xpc = @CLANGD_BUILD_XPC@
+config.clangd_build_dexp = @CLANGD_BUILD_DEXP@
 config.clangd_enable_remote = @CLANGD_ENABLE_REMOTE@
 config.clangd_tidy_checks = @CLANGD_TIDY_CHECKS@
 config.have_zlib = @LLVM_ENABLE_ZLIB@
diff --git a/llvm/utils/gn/secondary/clang-tools-extra/clangd/test/BUILD.gn b/llvm/utils/gn/secondary/clang-tools-extra/clangd/test/BUILD.gn
index 9d42409f1973f..8bfcb1282f0e5 100644
--- a/llvm/utils/gn/secondary/clang-tools-extra/clangd/test/BUILD.gn
+++ b/llvm/utils/gn/secondary/clang-tools-extra/clangd/test/BUILD.gn
@@ -77,7 +77,6 @@ group("test") {
   deps = [
     ":lit_site_cfg",
     ":lit_unit_site_cfg",
-    "//clang-tools-extra/clangd/index/dex/dexp",
     "//clang-tools-extra/clangd/indexer:clangd-indexer",
     "//clang-tools-extra/clangd/tool:clangd",
     "//clang-tools-extra/clangd/unittests:ClangdTests",
@@ -92,6 +91,11 @@ group("test") {
       "//clang-tools-extra/clangd/xpc/test-client:clangd-xpc-test-client",
     ]
   }
+  if (clangd_build_dexp) {
+    deps += [
+      "//clang-tools-extra/clangd/index/dex/dexp",
+    ]
+  }
   testonly = true
 }

clang-tools-extra/clangd/test/lit.site.cfg.py.in

Building dexp on Debian 11 currently causes intermittent failure[0][1]. Adding the CLANGD_BUILD_DEXP option to disable dexp from the build allows Debian 11 users to build clang (albeit without the dexp tool). This option is set to "Build Dexp" by default so, no change is expected without manual setting. [0]: https://bugzilla.yoctoproject.org/show_bug.cgi?id=15803 [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1101322

kraj

looks good to me.

Building dexp on Debian 11 currently causes intermittent failure[0][1]. Adding the CLANGD_BUILD_DEXP option to disable dexp from the build allows Debian 11 users to build clang (albeit without the dexp tool). This option is set to "Build Dexp" by default so, no change is expected without manual setting. [0]: https://bugzilla.yoctoproject.org/show_bug.cgi?id=15803 [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1101322 Upstream-Status: Submitted [llvm#133124] Signed-off-by: Yoann Congal <[email protected]> Signed-off-by: Khem Raj <[email protected]>

ycongal-smile · 2025-04-02T18:50:33Z

Ping

HighCommander4 · 2025-04-04T02:10:55Z

@kraj, you approved this and you are a project member, are you comfortable merging this? If so, please go ahead.

From my point of view as a clangd maintainer, I'm supportive of having such an option, but I have ~zero CMake knowledge, so if you think this needs more review, we need to find and add another reviewer.

kraj · 2025-04-04T03:28:15Z

@kraj, you approved this and you are a project member, are you comfortable merging this? If so, please go ahead.

From my point of view as a clangd maintainer, I'm supportive of having such an option, but I have ~zero CMake knowledge, so if you think this needs more review, we need to find and add another reviewer.

@HighCommander4 thanks, this has been tested in yocto autobuilder for few days already and I am happy with the change. Sadly, I don't see that I am able to merge it since I do not have write access

Building dexp on Debian 11 currently causes intermittent failure[0][1]. Adding the CLANGD_BUILD_DEXP option to disable dexp from the build allows Debian 11 users to build clang (albeit without the dexp tool). This option is set to "Build Dexp" by default so, no change is expected without manual setting. [0]: https://bugzilla.yoctoproject.org/show_bug.cgi?id=15803 [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1101322 Upstream-Status: Submitted [llvm#133124] Signed-off-by: Yoann Congal <[email protected]> Signed-off-by: Khem Raj <[email protected]>

ycongal-smile · 2025-04-13T20:36:28Z

ping
EDIT: Neither Khem nor I can merge so I need a member to do that for us (I think)

HighCommander4 · 2025-04-13T22:03:56Z

Ok, I went ahead and merged it.

github-actions · 2025-04-13T22:04:04Z

@ycongal-smile Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

ycongal-smile · 2025-04-14T08:35:23Z

I received 2 failing builds:

LLVM Buildbot: builder sanitizer-x86_64-linux-bootstrap-asan build 7561
- https://lab.llvm.org/buildbot/#/builders/52/builds/7561
LLVM Buildbot: builder sanitizer-x86_64-linux-fast build 10441
- https://lab.llvm.org/buildbot/#/builders/169/builds/10441

I've looked at the logs. IMHO it is an unrelated error : my change change if a single tool is built, the error is a single test related to address sanitation failing.

Building dexp on Debian 11 currently causes intermittent failures [0] [1]. Adding the CLANGD_BUILD_DEXP option to disable dexp from the build allows Debian 11 users to build clang (albeit without the dexp tool). This option is set to "Build Dexp" by default so, no change is expected without manual setting. [0]: https://bugzilla.yoctoproject.org/show_bug.cgi?id=15803 [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1101322

Building dexp on Debian 11 currently causes intermittent failure[0][1]. Adding the CLANGD_BUILD_DEXP option to disable dexp from the build allows Debian 11 users to build clang (albeit without the dexp tool). This option is set to "Build Dexp" by default so, no change is expected without manual setting. [0]: https://bugzilla.yoctoproject.org/show_bug.cgi?id=15803 [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1101322 Upstream-Status: Submitted [llvm#133124] Signed-off-by: Yoann Congal <[email protected]> Signed-off-by: Khem Raj <[email protected]>

llvmbot added clang-tools-extra clangd labels Mar 26, 2025

ycongal-smile mentioned this pull request Mar 26, 2025

clang: Disable building dexp in clang-native kraj/meta-clang#1066

Merged

3 tasks

ycongal-smile commented Mar 26, 2025

View reviewed changes

clang-tools-extra/clangd/test/lit.site.cfg.py.in Show resolved Hide resolved

ycongal-smile marked this pull request as draft March 26, 2025 21:45

ycongal-smile force-pushed the clangd_dexp_build_option branch from c547879 to 895bf3d Compare March 27, 2025 14:27

ycongal-smile force-pushed the clangd_dexp_build_option branch from 895bf3d to 8001f90 Compare March 27, 2025 14:28

ycongal-smile marked this pull request as ready for review March 27, 2025 15:18

kraj approved these changes Mar 27, 2025

View reviewed changes

HighCommander4 merged commit 3de9301 into llvm:main Apr 13, 2025
13 checks passed

ycongal-smile deleted the clangd_dexp_build_option branch April 14, 2025 08:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

clangd: Add a build option to disable building dexp #133124

clangd: Add a build option to disable building dexp #133124

Uh oh!

ycongal-smile commented Mar 26, 2025

Uh oh!

github-actions bot commented Mar 26, 2025

Uh oh!

llvmbot commented Mar 26, 2025

Uh oh!

llvmbot commented Mar 26, 2025

Uh oh!

Uh oh!

kraj left a comment

Uh oh!

ycongal-smile commented Apr 2, 2025

Uh oh!

HighCommander4 commented Apr 4, 2025

Uh oh!

kraj commented Apr 4, 2025 •

edited

Loading

Uh oh!

ycongal-smile commented Apr 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

HighCommander4 commented Apr 13, 2025

Uh oh!

github-actions bot commented Apr 13, 2025

Uh oh!

ycongal-smile commented Apr 14, 2025

Uh oh!

Uh oh!

clangd: Add a build option to disable building dexp #133124

clangd: Add a build option to disable building dexp #133124

Uh oh!

Conversation

ycongal-smile commented Mar 26, 2025

Uh oh!

github-actions bot commented Mar 26, 2025

Uh oh!

llvmbot commented Mar 26, 2025

Uh oh!

llvmbot commented Mar 26, 2025

Uh oh!

Uh oh!

kraj left a comment

Choose a reason for hiding this comment

Uh oh!

ycongal-smile commented Apr 2, 2025

Uh oh!

HighCommander4 commented Apr 4, 2025

Uh oh!

kraj commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ycongal-smile commented Apr 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

HighCommander4 commented Apr 13, 2025

Uh oh!

github-actions bot commented Apr 13, 2025

Uh oh!

ycongal-smile commented Apr 14, 2025

Uh oh!

Uh oh!

kraj commented Apr 4, 2025 •

edited

Loading

ycongal-smile commented Apr 13, 2025 •

edited

Loading