[github] remove more caches after downloading things

[gburgessiv]

This is generally good practice if the caches won't be reused (though arguably pedantic for the stage1-toolchain stage).

docker history on comparable images showed that this saves a few hundred MB on stage1, and ~60MB on the apt-get layer of ci-container-agent.

[llvmbot]

@llvm/pr-subscribers-github-workflow

Author: George Burgess IV (gburgessiv)

Changes

This is generally good practice if the caches won't be reused (though arguably pedantic for the stage1-toolchain stage).

docker history on comparable images showed that this saves a few hundred MB on stage1, and ~60MB on the apt-get layer of ci-container-agent.

---

Full diff: https://github.com/llvm/llvm-project/pull/133129.diff

1 Files Affected:

• (modified) .github/workflows/containers/github-action-ci/Dockerfile (+9-3)

diff --git a/.github/workflows/containers/github-action-ci/Dockerfile b/.github/workflows/containers/github-action-ci/Dockerfile
index bd3720017b7f7..11e020ad6ebef 100644
--- a/.github/workflows/containers/github-action-ci/Dockerfile
+++ b/.github/workflows/containers/github-action-ci/Dockerfile
@@ -14,9 +14,13 @@ RUN apt-get update && \
     python3 \
     git \
     curl \
-    zlib1g-dev
+    zlib1g-dev && \
+    apt-get clean && \
+    rm -rf /var/lib/apt/lists/*
 
-RUN curl -O -L https://github.com/llvm/llvm-project/archive/refs/tags/llvmorg-$LLVM_VERSION.tar.gz && tar -xf llvmorg-$LLVM_VERSION.tar.gz
+RUN curl -O -L https://github.com/llvm/llvm-project/archive/refs/tags/llvmorg-$LLVM_VERSION.tar.gz && \
+  tar -xf llvmorg-$LLVM_VERSION.tar.gz && \
+  rm -f llvmorg-$LLVM_VERSION.tar.gz
 
 WORKDIR /llvm-project-llvmorg-$LLVM_VERSION
 
@@ -65,7 +69,9 @@ RUN apt-get update && \
     python3-pip \
     ccache \
     file \
-    tzdata
+    tzdata && \
+    apt-get clean && \
+    rm -rf /var/lib/apt/lists/*
 
 # Install sccache as it is needed by most of the project test workflows and
 # cannot be installed by the ccache action when executing as a non-root user.

[boomanaiden154]

Seems reasonable enough to me.

I believe there are some workflows that use this container and run apt-get inside of it. Theoretically they should be also running apt-get update just in case the containers get too out of date. I'll need to double check.

[boomanaiden154]

LGTM. None of the other workflows run apt-get, so this should be good to go.

A 60MB savings on the agent image is pretty nice.

[gburgessiv]

Nice - thanks for the review!