Skip to content

[compiler-rt][tests][AIX] Use /opt/freeware/bin/env #133160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

hubert-reinterpretcast
Copy link
Collaborator

env -u is not supported by the system env utility on AIX.
/opt/freeware/bin/env is the standard path for the GNU coreutils env utility as distributed by the AIX Toolbox for Open Source Software.
Adding /opt/freeware/bin to PATH causes issues by picking up other utilities that are less capable, in an AIX context, than the system ones.
This patch modifies the relevant usage of env to use (on AIX) the full path to /opt/freeware/bin/env.

`env -u` is not supported by the system `env` utility on AIX.
Copy link
Member

@daltenty daltenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@mustartt mustartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hubert-reinterpretcast hubert-reinterpretcast merged commit 7712de3 into main Mar 27, 2025
12 checks passed
@hubert-reinterpretcast hubert-reinterpretcast deleted the users/hubert-reinterpretcast/nfc-test-fixAixEnvUtility branch March 27, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants