[llvm][cmake] Quote CMAKE_CXX_COMPILER_ID in string comparison #133332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're seeing following configuration error when building the `runtimes` target on our buildbots:
```
CMake Error at /Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-sanitized/llvm-project/llvm/cmake/modules/CheckProblematicConfigurations.cmake:14 (if):
if given arguments:
"STREQUAL" "MSVC"
Unknown arguments specified
Call Stack (most recent call first):
/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-sanitized/llvm-project/llvm/cmake/modules/HandleLLVMOptions.cmake:10 (include)
CMakeLists.txt:175 (include)
```
If I understand correctly this happens because ${CMAKE_CXX_COMPILER_ID}
is empty. Quoting it should make the comparison work for those cases.
bulbazord
reviewed
Mar 27, 2025
| @@ -11,7 +11,7 @@ endmacro() | |||
|
|
|||
| # MSVC and /arch:AVX is untested and have created problems before. See: | |||
| # https://github.com/llvm/llvm-project/issues/54645 | |||
| if(${CMAKE_CXX_COMPILER_ID} STREQUAL MSVC) | |||
| if("${CMAKE_CXX_COMPILER_ID}" STREQUAL MSVC) | |||
There was a problem hiding this comment.
Based on the error message, it's likely that CMAKE_CXX_COMPILER_ID as a variable is empty or not defined. Expanding the variable here effectively turns this into if( STREQUAL MSVC), which is why the error complains about only seeing those two.
I would recommend changing your solution to:
if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC"). This makes it clear that the former is a variable and the latter is a string.
There was a problem hiding this comment.
Sounds good! That seems to also be how we do it elsewhere in the codebase
bulbazord
approved these changes
Mar 27, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/15044 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing following configuration error when building the
runtimestarget on our buildbots:If I understand correctly this happens because ${CMAKE_CXX_COMPILER_ID} is empty. Quoting it should make the comparison work for those cases.