Skip to content

[mlir][arith] Trim trailing spaces in wide int emulation tests. NFC. #133349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2025
Merged

[mlir][arith] Trim trailing spaces in wide int emulation tests. NFC. #133349

merged 1 commit into from
Mar 28, 2025

Conversation

kuhar
Copy link
Member

@kuhar kuhar commented Mar 28, 2025 •
edited
Loading

Followup cleanup after #132375 and #133248

@kuhar kuhar requested review from krzysz00 and andfau-amd March 28, 2025 01:03
@kuhar
Copy link
Member Author

kuhar commented Mar 28, 2025

cc: @egebeysel

@llvmbot
Copy link
Member

llvmbot commented Mar 28, 2025

@llvm/pr-subscribers-mlir

Author: Jakub Kuderski (kuhar)

Changes

Follow up cleanup after #132375 and #133248

Full diff: https://github.com/llvm/llvm-project/pull/133349.diff

3 Files Affected:

  • (modified) mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptosi-i64.mlir (+2-3)
  • (modified) mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptoui-i64.mlir (+1-1)
  • (modified) mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-subi-i32.mlir (+6-7)
diff --git a/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptosi-i64.mlir b/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptosi-i64.mlir
index d93b834c8f919..0bce669461d3b 100644
--- a/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptosi-i64.mlir
+++ b/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptosi-i64.mlir
@@ -35,13 +35,12 @@ func.func @entry() {
 
   %cstpow20 = arith.constant 1048576.0 : f64
   %cstnpow20 = arith.constant -1048576.0 : f64
-  
+
   %cst_i32_max = arith.constant 4294967295.0 : f64
   %cst_i32_min = arith.constant -4294967296.0 : f64
   %cst_i32_overflow = arith.constant 4294967296.0 : f64
   %cst_i32_noverflow = arith.constant -4294967297.0 : f64
 
-
   %cstpow40 = arith.constant 1099511627776.0 : f64
   %cstnpow40 = arith.constant -1099511627776.0 : f64
   %cst_pow40ppow20 = arith.constant 1099512676352.0 : f64
@@ -49,7 +48,7 @@ func.func @entry() {
 
   %cst_max = arith.constant 9007199254740992.0
   %cst_min = arith.constant -9007199254740992.0
-  
+
   // CHECK:         0
   func.call @check_fptosi(%cst0) : (f64) -> ()
   // CHECK-NEXT:    0
diff --git a/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptoui-i64.mlir b/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptoui-i64.mlir
index 81283ee9fdfd8..5d3de8c24e3fa 100644
--- a/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptoui-i64.mlir
+++ b/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptoui-i64.mlir
@@ -40,7 +40,7 @@ func.func @entry() {
   %cst_pow40ppow20 = arith.constant 1099512676352.0 : f64
 
   %cst_nzero = arith.constant 0x8000000000000000 : f64
-  
+
   // CHECK:         0
   func.call @check_fptoui(%cst0) : (f64) -> ()
   // CHECK-NEXT:    1
diff --git a/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-subi-i32.mlir b/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-subi-i32.mlir
index 63d2c941c48e7..05423b754b258 100644
--- a/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-subi-i32.mlir
+++ b/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-subi-i32.mlir
@@ -32,7 +32,7 @@ func.func @entry() {
   func.call @check_subi(%lhs1, %rhs1) : (i32, i32) -> ()
   // CHECK-NEXT:  1
   func.call @check_subi(%rhs1, %lhs1) : (i32, i32) -> ()
-  
+
   %lhs2 = arith.constant 1 : i32
   %rhs2 = arith.constant -2 : i32
 
@@ -40,7 +40,7 @@ func.func @entry() {
   func.call @check_subi(%lhs2, %rhs2) : (i32, i32) -> ()
   // CHECK-NEXT:  -3
   func.call @check_subi(%rhs2, %lhs2) : (i32, i32) -> ()
-  
+
   %lhs3 = arith.constant -1 : i32
   %rhs3 = arith.constant -2 : i32
 
@@ -48,7 +48,7 @@ func.func @entry() {
   func.call @check_subi(%lhs3, %rhs3) : (i32, i32) -> ()
   // CHECK-NEXT:  -1
   func.call @check_subi(%rhs3, %lhs3) : (i32, i32) -> ()
-  
+
   // Overflow from the upper/lower part.
   %lhs4 = arith.constant 131074 : i32
   %rhs4 = arith.constant 3 : i32
@@ -59,7 +59,7 @@ func.func @entry() {
   func.call @check_subi(%rhs4, %lhs4) : (i32, i32) -> ()
 
   // Overflow in both parts.
-  %lhs5 = arith.constant 16385027 : i32 
+  %lhs5 = arith.constant 16385027 : i32
   %rhs5 = arith.constant 16450564 : i32
 
   // CHECK-NEXT:  -65537
@@ -67,7 +67,7 @@ func.func @entry() {
   // CHECK-NEXT:  65537
   func.call @check_subi(%rhs5, %lhs5) : (i32, i32) -> ()
 
-  %lhs6 = arith.constant 65536 : i32 
+  %lhs6 = arith.constant 65536 : i32
   %rhs6 = arith.constant 1 : i32
 
   // CHECK-NEXT:  65535
@@ -76,7 +76,7 @@ func.func @entry() {
   func.call @check_subi(%rhs6, %lhs6) : (i32, i32) -> ()
 
   // Max/Min (un)signed integers.
-  %sintmax = arith.constant 2147483647 : i32 
+  %sintmax = arith.constant 2147483647 : i32
   %sintmin = arith.constant -2147483648 : i32
   %uintmax = arith.constant -1 : i32
   %uintmin = arith.constant 0 : i32
@@ -98,7 +98,6 @@ func.func @entry() {
   func.call @check_subi(%uintmin, %cst1) : (i32, i32) -> ()
   // CHECK-NEXT:  1
   func.call @check_subi(%uintmin, %uintmax) : (i32, i32) -> ()
-  
 
   return
 }

@llvmbot
Copy link
Member

llvmbot commented Mar 28, 2025

@llvm/pr-subscribers-mlir-arith

Author: Jakub Kuderski (kuhar)

Changes

Follow up cleanup after #132375 and #133248

Full diff: https://github.com/llvm/llvm-project/pull/133349.diff

3 Files Affected:

  • (modified) mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptosi-i64.mlir (+2-3)
  • (modified) mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptoui-i64.mlir (+1-1)
  • (modified) mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-subi-i32.mlir (+6-7)
diff --git a/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptosi-i64.mlir b/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptosi-i64.mlir
index d93b834c8f919..0bce669461d3b 100644
--- a/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptosi-i64.mlir
+++ b/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptosi-i64.mlir
@@ -35,13 +35,12 @@ func.func @entry() {
 
   %cstpow20 = arith.constant 1048576.0 : f64
   %cstnpow20 = arith.constant -1048576.0 : f64
-  
+
   %cst_i32_max = arith.constant 4294967295.0 : f64
   %cst_i32_min = arith.constant -4294967296.0 : f64
   %cst_i32_overflow = arith.constant 4294967296.0 : f64
   %cst_i32_noverflow = arith.constant -4294967297.0 : f64
 
-
   %cstpow40 = arith.constant 1099511627776.0 : f64
   %cstnpow40 = arith.constant -1099511627776.0 : f64
   %cst_pow40ppow20 = arith.constant 1099512676352.0 : f64
@@ -49,7 +48,7 @@ func.func @entry() {
 
   %cst_max = arith.constant 9007199254740992.0
   %cst_min = arith.constant -9007199254740992.0
-  
+
   // CHECK:         0
   func.call @check_fptosi(%cst0) : (f64) -> ()
   // CHECK-NEXT:    0
diff --git a/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptoui-i64.mlir b/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptoui-i64.mlir
index 81283ee9fdfd8..5d3de8c24e3fa 100644
--- a/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptoui-i64.mlir
+++ b/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-fptoui-i64.mlir
@@ -40,7 +40,7 @@ func.func @entry() {
   %cst_pow40ppow20 = arith.constant 1099512676352.0 : f64
 
   %cst_nzero = arith.constant 0x8000000000000000 : f64
-  
+
   // CHECK:         0
   func.call @check_fptoui(%cst0) : (f64) -> ()
   // CHECK-NEXT:    1
diff --git a/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-subi-i32.mlir b/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-subi-i32.mlir
index 63d2c941c48e7..05423b754b258 100644
--- a/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-subi-i32.mlir
+++ b/mlir/test/Integration/Dialect/Arith/CPU/test-wide-int-emulation-subi-i32.mlir
@@ -32,7 +32,7 @@ func.func @entry() {
   func.call @check_subi(%lhs1, %rhs1) : (i32, i32) -> ()
   // CHECK-NEXT:  1
   func.call @check_subi(%rhs1, %lhs1) : (i32, i32) -> ()
-  
+
   %lhs2 = arith.constant 1 : i32
   %rhs2 = arith.constant -2 : i32
 
@@ -40,7 +40,7 @@ func.func @entry() {
   func.call @check_subi(%lhs2, %rhs2) : (i32, i32) -> ()
   // CHECK-NEXT:  -3
   func.call @check_subi(%rhs2, %lhs2) : (i32, i32) -> ()
-  
+
   %lhs3 = arith.constant -1 : i32
   %rhs3 = arith.constant -2 : i32
 
@@ -48,7 +48,7 @@ func.func @entry() {
   func.call @check_subi(%lhs3, %rhs3) : (i32, i32) -> ()
   // CHECK-NEXT:  -1
   func.call @check_subi(%rhs3, %lhs3) : (i32, i32) -> ()
-  
+
   // Overflow from the upper/lower part.
   %lhs4 = arith.constant 131074 : i32
   %rhs4 = arith.constant 3 : i32
@@ -59,7 +59,7 @@ func.func @entry() {
   func.call @check_subi(%rhs4, %lhs4) : (i32, i32) -> ()
 
   // Overflow in both parts.
-  %lhs5 = arith.constant 16385027 : i32 
+  %lhs5 = arith.constant 16385027 : i32
   %rhs5 = arith.constant 16450564 : i32
 
   // CHECK-NEXT:  -65537
@@ -67,7 +67,7 @@ func.func @entry() {
   // CHECK-NEXT:  65537
   func.call @check_subi(%rhs5, %lhs5) : (i32, i32) -> ()
 
-  %lhs6 = arith.constant 65536 : i32 
+  %lhs6 = arith.constant 65536 : i32
   %rhs6 = arith.constant 1 : i32
 
   // CHECK-NEXT:  65535
@@ -76,7 +76,7 @@ func.func @entry() {
   func.call @check_subi(%rhs6, %lhs6) : (i32, i32) -> ()
 
   // Max/Min (un)signed integers.
-  %sintmax = arith.constant 2147483647 : i32 
+  %sintmax = arith.constant 2147483647 : i32
   %sintmin = arith.constant -2147483648 : i32
   %uintmax = arith.constant -1 : i32
   %uintmin = arith.constant 0 : i32
@@ -98,7 +98,6 @@ func.func @entry() {
   func.call @check_subi(%uintmin, %cst1) : (i32, i32) -> ()
   // CHECK-NEXT:  1
   func.call @check_subi(%uintmin, %uintmax) : (i32, i32) -> ()
-  
 
   return
 }

@kuhar kuhar requested a review from kazutakahirata March 28, 2025 02:18
kazutakahirata
kazutakahirata approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@kazutakahirata kazutakahirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kuhar kuhar merged commit f359c0b into llvm:main Mar 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazutakahirata kazutakahirata kazutakahirata approved these changes

@krzysz00 krzysz00 Awaiting requested review from krzysz00

@andfau-amd andfau-amd Awaiting requested review from andfau-amd

Assignees
No one assigned
Labels
mlir:arith mlir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuhar @llvmbot @kazutakahirata