Skip to content

[Format] Use a range constructor of DenseSet (NFC) #133382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kazutakahirata
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Mar 28, 2025

@llvm/pr-subscribers-clang-format

Author: Kazu Hirata (kazutakahirata)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/133382.diff

1 Files Affected:

  • (modified) clang/lib/Format/MacroCallReconstructor.cpp (+3-3)
diff --git a/clang/lib/Format/MacroCallReconstructor.cpp b/clang/lib/Format/MacroCallReconstructor.cpp
index 101acefdfe7a3..f69a6aabc7d47 100644
--- a/clang/lib/Format/MacroCallReconstructor.cpp
+++ b/clang/lib/Format/MacroCallReconstructor.cpp
@@ -365,9 +365,9 @@ void MacroCallReconstructor::endReconstruction(FormatToken *Token) {
 }
 
 void MacroCallReconstructor::debugParentMap() const {
-  llvm::DenseSet<FormatToken *> Values;
-  for (const auto &P : SpelledParentToReconstructedParent)
-    Values.insert(P.second);
+  llvm::DenseSet<FormatToken *> Values(
+      llvm::from_range,
+      llvm::make_second_range(SpelledParentToReconstructedParent));
 
   for (const auto &P : SpelledParentToReconstructedParent) {
     if (Values.contains(P.first))

@kazutakahirata kazutakahirata merged commit 4382903 into llvm:main Mar 28, 2025
13 checks passed
@kazutakahirata kazutakahirata deleted the cleanup_001_set_range_clang branch March 28, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants