llvm-reduce: Filter function based on uses before removing arguments #133412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 28, 2025
arsenm
force-pushed
the
users/arsenm/llvm-reduce/fix-remove-argument-losing-callsite-calling-conv
branch
from
0e49d45 to
450bceb
Compare
arsenm
force-pushed
the
users/arsenm/llvm-reduce/filter-function-use-types-before-remove-arguments
branch
from
0ff2f75 to
91d3247
Compare
This was referenced Mar 28, 2025
|
LGTM! |
1 similar comment
|
LGTM! |
arsenm
force-pushed
the
users/arsenm/llvm-reduce/fix-remove-argument-losing-callsite-calling-conv
branch
from
450bceb to
dc033ac
Compare
arsenm
force-pushed
the
users/arsenm/llvm-reduce/filter-function-use-types-before-remove-arguments
branch
from
91d3247 to
374d2d9
Compare
arsenm
force-pushed
the
users/arsenm/llvm-reduce/fix-remove-argument-losing-callsite-calling-conv
branch
from
dc033ac to
c88f4ef
Compare
arsenm
force-pushed
the
users/arsenm/llvm-reduce/filter-function-use-types-before-remove-arguments
branch
from
374d2d9 to
834ae84
Compare
arsenm
force-pushed
the
users/arsenm/llvm-reduce/fix-remove-argument-losing-callsite-calling-conv
branch
from
c88f4ef to
abe9ab2
Compare
Base automatically changed from
users/arsenm/llvm-reduce/fix-remove-argument-losing-callsite-calling-conv
to
main
March 28, 2025 16:51
Invokes and others are not handled, so this was leaving broken callsites behind for anything other than CallInst
arsenm
force-pushed
the
users/arsenm/llvm-reduce/filter-function-use-types-before-remove-arguments
branch
from
834ae84 to
e1fe44b
Compare
Merge activity
|
arsenm
deleted the
users/arsenm/llvm-reduce/filter-function-use-types-before-remove-arguments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invokes and others are not handled, so this was leaving broken callsites
behind for anything other than CallInst