[libc] Add maintainers file #133471
Merged
[libc] Add maintainers file #133471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on llvm#133297 by jhuber. LLVM-libc needs a maintainers file, this patch adds an initial set. The file is based on `clang/maintainers.rst` and https://llvm.org/docs/DeveloperPolicy.html#maintainers.
|
Marked as draft for now since I want to get feedback before landing.
|
jhuber6
approved these changes
Mar 28, 2025
I'm willing to add you, do you feel comfortable fulfilling all the duties listed here: https://llvm.org/docs/DeveloperPolicy.html#maintainers ? |
|
Yes |
overmighty
reviewed
Mar 28, 2025
|
Should the "Other subprojects" section of llvm/Maintainers.md be updated to link to the libc maintainers file? |
|
I've added the requested maintainers, added a page on the website for this, and added this to the list of LLVM subprojects. I'm going to mark this as ready for review in case other people would like to comment. |
|
@llvm/pr-subscribers-libc Author: Michael Jones (michaelrj-google) ChangesBased on #133297 by jhuber. LLVM-libc needs a maintainers file, this patch adds an initial set. Full diff: https://github.com/llvm/llvm-project/pull/133471.diff 5 Files Affected:
diff --git a/libc/Maintainers.rst b/libc/Maintainers.rst
new file mode 100644
index 0000000000000..a525d8e8df63d
--- /dev/null
+++ b/libc/Maintainers.rst
@@ -0,0 +1,42 @@
+=====================
+LLVM-libc Maintainers
+=====================
+
+This file is a list of the
+`maintainers <https://llvm.org/docs/DeveloperPolicy.html#maintainers>`_ for
+LLVM-libc. The following people are the active maintainers for the project.
+Please reach out to them for code reviews, questions about their area of
+expertise, or other assistance.
+
+.. contents::
+ :depth: 1
+ :local:
+
+Lead Maintainer
+---------------
+| Michael Jones
+| michaelrj\@google.com (email), `michaelrj-google <https://github.com/michaelrj-google>`_ (github)
+
+GPU
+---
+| Joseph Huber
+| joseph.huber\@amd.com (email), `jhuber6 <https://github.com/jhuber6>`_ (github)
+
+Math
+----
+| Tue Ly
+| lntue\@google.com (email), `lntue <https://github.com/lntue>`_ (github)
+| Nicolas Celik
+| its.overmighty\@gmail.com (email), `OverMighty <https://github.com/overmighty>`_ (github)
+
+Threading
+---------
+| Yifan Zhu
+| yifanzhu\@rochester.edu (email), `Schrodinger ZHU Yifan <https://github.com/schrodingerzhu>`_ (github)
+
+UEFI
+----
+| Tristan Ross
+| tristan.ross\@midstall.com (email), `RossComputerGuy <https://github.com/RossComputerGuy>`_ (github)
+
+.. TODO: add "Inactive Maintainers" section when needed.
diff --git a/libc/docs/CMakeLists.txt b/libc/docs/CMakeLists.txt
index 150ee2085160a..5b89511c33bdc 100644
--- a/libc/docs/CMakeLists.txt
+++ b/libc/docs/CMakeLists.txt
@@ -8,7 +8,12 @@ if (SPHINX_FOUND)
# want the dynamically generated .rst files to pollute the source tree.
add_custom_target(copy-libc-rst-docs
COMMAND "${CMAKE_COMMAND}" -E copy_directory
- "${CMAKE_CURRENT_SOURCE_DIR}" "${CMAKE_CURRENT_BINARY_DIR}")
+ "${CMAKE_CURRENT_SOURCE_DIR}" "${CMAKE_CURRENT_BINARY_DIR}"
+
+ COMMAND "${CMAKE_COMMAND}" -E copy_if_different
+ "${CMAKE_CURRENT_SOURCE_DIR}/../Maintainers.rst"
+ "${CMAKE_CURRENT_BINARY_DIR}"
+ )
# For headers that are nested in directories, we need to
# `mkdir $build_dir/libc/docs/headers/$dir` since the above copy_directory
diff --git a/libc/docs/Maintainers.rst b/libc/docs/Maintainers.rst
new file mode 100644
index 0000000000000..7e69c1165d2f5
--- /dev/null
+++ b/libc/docs/Maintainers.rst
@@ -0,0 +1 @@
+.. include:: ../Maintainers.rst
diff --git a/libc/docs/index.rst b/libc/docs/index.rst
index bf982cc456349..7238d1383511e 100644
--- a/libc/docs/index.rst
+++ b/libc/docs/index.rst
@@ -71,6 +71,7 @@ LLVM-libc aspires to a unique place in the software ecosystem. The goals are:
:maxdepth: 1
:caption: Development
+ Maintainers
build_and_test
dev/index.rst
porting
diff --git a/llvm/Maintainers.md b/llvm/Maintainers.md
index 47e936e0c39eb..fbb170cec8737 100644
--- a/llvm/Maintainers.md
+++ b/llvm/Maintainers.md
@@ -467,6 +467,8 @@ Some subprojects maintain their own list of per-component maintainers.
[libc++ maintainers](https://github.com/llvm/llvm-project/blob/main/libcxx/Maintainers.md)
+[Libc maintainers](https://github.com/llvm/llvm-project/blob/main/libc/Maintainers.rst)
+
[libclc maintainers](https://github.com/llvm/llvm-project/blob/main/libclc/Maintainers.md)
[LLD maintainers](https://github.com/llvm/llvm-project/blob/main/lld/Maintainers.md)
|
|
LGTM |
michaelrj-google
requested review from
RossComputerGuy,
overmighty,
lntue and
SchrodingerZhu
|
I've requested review from everyone listed (except for myself). I'll merge this once everyone has approved |
RossComputerGuy
approved these changes
Mar 28, 2025
|
@PiJoules for stdfix? |
If he wants to I'm willing to add him, but he can also propose his own CL after this one has landed. |
SchrodingerZhu
approved these changes
Mar 28, 2025
Yeah I'd love to be an owner :) |
|
I'll sign up for Baremetal if you're looking for a maintainer. |
PiJoules
approved these changes
Mar 28, 2025
|
I've added you two as well. I think any further additions should probably be in a followup patch so this one doesn't keep growing forever. |
petrhosek
approved these changes
Mar 28, 2025
overmighty
approved these changes
Mar 28, 2025
lntue
approved these changes
Mar 28, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/198/builds/3246 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #133297 by jhuber.
LLVM-libc needs a maintainers file, this patch adds an initial set.
The file is based on
clang/maintainers.rstandhttps://llvm.org/docs/DeveloperPolicy.html#maintainers.