-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[SandboxVec][Doc] Add documentation for the Sandbox Vectorizer #133504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor comments.
llvm/docs/SandboxVectorizer.md
Outdated
``` | ||
┌────────────────────────────────── Sandbox Vectorizer LLVM Function Pass ─────────────────────────────┐ | ||
│ │ | ||
│ ┌───────┐ ┌────────────────────────── sanboxir::Function Pass Manager ─────────────────────────────┐ │ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: "sanboxir"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
llvm/docs/SandboxVectorizer.md
Outdated
| `tr-accept` | TransactionAlwaysAccept.h | Region | Unconditionally accepts the IR state | | ||
| `tr-revert` | TransactionAlwaysRevert.h | Region | Unconditionally rejects the IR state | | ||
| `tr-accept-or-revert` | TransactionAcceptOrRevert.h | Region | Checks cost model and either accepts or reverts the IR | | ||
| `null` | NullPass.h | Region | A test pass that prints the region instructions | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The null pass doesn't print anything, that would be the new print-region pass in #131019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Fixed.
I also added one line for #131019
llvm/docs/SandboxVectorizer.md
Outdated
|
||
One of the great things about the Sandbox Vectorizer is that it allows you to test each internal pass in isolation with lit-tests. | ||
|
||
Testing Function passes are straightforward, just run `FUNCTION_PASS` in isolation with `-sbvec-passes`, like so: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "Testing Function passes is straightforward".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed comments and rebased.
llvm/docs/SandboxVectorizer.md
Outdated
``` | ||
┌────────────────────────────────── Sandbox Vectorizer LLVM Function Pass ─────────────────────────────┐ | ||
│ │ | ||
│ ┌───────┐ ┌────────────────────────── sanboxir::Function Pass Manager ─────────────────────────────┐ │ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
llvm/docs/SandboxVectorizer.md
Outdated
| `tr-accept` | TransactionAlwaysAccept.h | Region | Unconditionally accepts the IR state | | ||
| `tr-revert` | TransactionAlwaysRevert.h | Region | Unconditionally rejects the IR state | | ||
| `tr-accept-or-revert` | TransactionAcceptOrRevert.h | Region | Checks cost model and either accepts or reverts the IR | | ||
| `null` | NullPass.h | Region | A test pass that prints the region instructions | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! Fixed.
I also added one line for #131019
llvm/docs/SandboxVectorizer.md
Outdated
|
||
One of the great things about the Sandbox Vectorizer is that it allows you to test each internal pass in isolation with lit-tests. | ||
|
||
Testing Function passes are straightforward, just run `FUNCTION_PASS` in isolation with `-sbvec-passes`, like so: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
No description provided.