[llvm-reduce]: print short form, actionable names in the log #133561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
arsenm
reviewed
Mar 29, 2025
| void llvm::reduceIFuncsDeltaPass(TestRunner &Test) { | ||
| runDeltaPass(Test, extractIFuncsFromModule, "Reducing Ifuncs"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Missing newline at end of file errors
Suggested change
| } | |
| } | |
| void llvm::reduceArgumentsDeltaPass(TestRunner &Test) { | ||
| runDeltaPass(Test, extractArgumentsFromModule, "Reducing Arguments"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
More of these
| void llvm::reduceDIMetadataDeltaPass(TestRunner &Test) { | ||
| runDeltaPass(Test, extractDIMetadataFromModule, "Reducing DIMetadata"); | ||
| } | ||
| } |
| void llvm::reduceDbgRecordDeltaPass(TestRunner &Test) { | ||
| runDeltaPass(Test, extractDbgRecordsFromModule, "Reducing DbgRecords"); | ||
| } | ||
| } |
| runDeltaPass(Test, extractDistinctMetadataFromModule, | ||
| "Reducing Distinct Metadata"); | ||
| } | ||
| } |
| DELTA_PASS_MIR("register-uses", reduceRegisterUsesMIRDeltaPass,"Reducing register uses") | ||
| DELTA_PASS_MIR("register-defs", reduceRegisterDefsMIRDeltaPass,"Reducing register defs") | ||
| DELTA_PASS_MIR("register-hints", reduceVirtualRegisterHintsDeltaPass,"Reducing virtual register hints from functions") | ||
| DELTA_PASS_MIR("register-masks", reduceRegisterMasksMIRDeltaPass,"Reducing register masks") |
There was a problem hiding this comment.
Suggested change
| DELTA_PASS_MIR("register-masks", reduceRegisterMasksMIRDeltaPass,"Reducing register masks") | |
| DELTA_PASS_MIR("register-masks", reduceRegisterMasksMIRDeltaPass,"Reducing register masks") | |
| DELTA_PASS_MIR("instructions", reduceInstructionsMIRDeltaPass, "Reducing Instructions") | ||
| DELTA_PASS_MIR("ir-instruction-references", | ||
| reduceIRInstructionReferencesDeltaPass,"Reducing IR references from instructions") | ||
| DELTA_PASS_MIR("ir-block-references", reduceIRBlockReferencesDeltaPass,"Reducing IR references from blocks") |
There was a problem hiding this comment.
Suggested change
| DELTA_PASS_MIR("ir-block-references", reduceIRBlockReferencesDeltaPass,"Reducing IR references from blocks") | |
| DELTA_PASS_MIR("ir-block-references", reduceIRBlockReferencesDeltaPass, "Reducing IR references from blocks") |
| DELTA_PASS_MIR("ir-instruction-references", | ||
| reduceIRInstructionReferencesDeltaPass,"Reducing IR references from instructions") | ||
| DELTA_PASS_MIR("ir-block-references", reduceIRBlockReferencesDeltaPass,"Reducing IR references from blocks") | ||
| DELTA_PASS_MIR("ir-function-references", reduceIRFunctionReferencesDeltaPass,"Reducing IR references from functions") |
There was a problem hiding this comment.
Suggested change
| DELTA_PASS_MIR("ir-function-references", reduceIRFunctionReferencesDeltaPass,"Reducing IR references from functions") | |
| DELTA_PASS_MIR("ir-function-references", reduceIRFunctionReferencesDeltaPass, "Reducing IR references from functions") |
Suggested change
| DELTA_PASS_MIR("ir-function-references", reduceIRFunctionReferencesDeltaPass,"Reducing IR references from functions") | |
| DELTA_PASS_MIR("ir-function-references", reduceIRFunctionReferencesDeltaPass,"Reducing IR references from functions") |
Comment on lines
65
to
68
| DELTA_PASS_MIR("register-uses", reduceRegisterUsesMIRDeltaPass,"Reducing register uses") | ||
| DELTA_PASS_MIR("register-defs", reduceRegisterDefsMIRDeltaPass,"Reducing register defs") | ||
| DELTA_PASS_MIR("register-hints", reduceVirtualRegisterHintsDeltaPass,"Reducing virtual register hints from functions") | ||
| DELTA_PASS_MIR("register-masks", reduceRegisterMasksMIRDeltaPass,"Reducing register masks") |
There was a problem hiding this comment.
Suggested change
| DELTA_PASS_MIR("register-uses", reduceRegisterUsesMIRDeltaPass,"Reducing register uses") | |
| DELTA_PASS_MIR("register-defs", reduceRegisterDefsMIRDeltaPass,"Reducing register defs") | |
| DELTA_PASS_MIR("register-hints", reduceVirtualRegisterHintsDeltaPass,"Reducing virtual register hints from functions") | |
| DELTA_PASS_MIR("register-masks", reduceRegisterMasksMIRDeltaPass,"Reducing register masks") | |
| DELTA_PASS_MIR("register-uses", reduceRegisterUsesMIRDeltaPass, "Reducing register uses") | |
| DELTA_PASS_MIR("register-defs", reduceRegisterDefsMIRDeltaPass, "Reducing register defs") | |
| DELTA_PASS_MIR("register-hints", reduceVirtualRegisterHintsDeltaPass, "Reducing virtual register hints from functions") | |
| DELTA_PASS_MIR("register-masks", reduceRegisterMasksMIRDeltaPass, "Reducing register masks") |
| DELTA_PASSES_MIR; | ||
| for (const DeltaPass &Pass : MIR_Passes) { | ||
| if (PassName == Pass.Name) { | ||
| runDeltaPass(Tester, Pass.Func, getPassMessage(Pass)); |
There was a problem hiding this comment.
You can simplify this by making runDeltaPass take const DeltaPass &. You don't need to build the intermediate string, the final print can directly consume the DeltaPass fields
|
@arsenm Done. |
|
@arsenm I've learned a lot. Thanks. |
SchrodingerZhu
pushed a commit
to SchrodingerZhu/llvm-project
that referenced
this pull request
Mar 31, 2025
…3561) Closes llvm#132696 before the patch like this: ``` ---------------------------- *** Reducing GlobalObjects... ---------------------------- *** Reducing GV Initializers... ---------------------------- *** Reducing GlobalVariables... ---------------------------- ``` after the patch like this: ``` ---------------------------- *** Reducing GlobalObjects (global-objects)... ---------------------------- *** Reducing GV Initializers (global-initializers)... ---------------------------- *** Reducing GlobalVariables (global-variables)... ---------------------------- ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #132696
before the patch like this:
after the patch like this: