llvm-reduce: Make run-ir-passes error more consistent #133564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
LGTM! |
arsenm
force-pushed
the
users/arsenm/llvm-reduce/run-ir-passes-error-handling
branch
from
dd57219 to
f3d8f2b
Compare
arsenm
force-pushed
the
users/arsenm/llvm-reduce/make-error-messages-more-consistent
branch
from
d849ebb to
b102b37
Compare
Base automatically changed from
users/arsenm/llvm-reduce/make-error-messages-more-consistent
to
main
March 29, 2025 07:11
Avoid capitalized Error. This loses the "Error constructing pass pipeline" part, and just forwards the error to the default report_fatal_error case. Not sure if it's worth trying to keep.
arsenm
force-pushed
the
users/arsenm/llvm-reduce/run-ir-passes-error-handling
branch
from
f3d8f2b to
7747fd7
Compare
arsenm
deleted the
users/arsenm/llvm-reduce/run-ir-passes-error-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid capitalized Error. This loses the "Error constructing pass pipeline"
part, and just forwards the error to the default report_fatal_error case. Not
sure if it's worth trying to keep.