[Github] Bump workflows depending on CI container to ubuntu 24.04 #133626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch bumps workflows depending upon the Linux CI container to ubuntu 24.04. The 22.04 container is no longer being built as it was recently bumped to 24.04, so this patch moves all of these workflows over to the new container to keep them updated and ensure they are using an actually maintained version of the container image.
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThis patch bumps workflows depending upon the Linux CI container to ubuntu 24.04. The 22.04 container is no longer being built as it was recently bumped to 24.04, so this patch moves all of these workflows over to the new container to keep them updated and ensure they are using an actually maintained version of the container image. Full diff: https://github.com/llvm/llvm-project/pull/133626.diff 4 Files Affected:
diff --git a/.github/workflows/ci-post-commit-analyzer.yml b/.github/workflows/ci-post-commit-analyzer.yml
index e0d30b66f66b6..b8074859d23a2 100644
--- a/.github/workflows/ci-post-commit-analyzer.yml
+++ b/.github/workflows/ci-post-commit-analyzer.yml
@@ -34,9 +34,9 @@ jobs:
if: >-
github.repository_owner == 'llvm' &&
github.event.action != 'closed'
- runs-on: ubuntu-22.04
+ runs-on: ubuntu-24.04
container:
- image: 'ghcr.io/llvm/ci-ubuntu-22.04:latest'
+ image: 'ghcr.io/llvm/ci-ubuntu-24.04:latest'
env:
LLVM_VERSION: 18
steps:
diff --git a/.github/workflows/libclang-python-tests.yml b/.github/workflows/libclang-python-tests.yml
index cbfb3e5cbabfe..50ef4acf2feb1 100644
--- a/.github/workflows/libclang-python-tests.yml
+++ b/.github/workflows/libclang-python-tests.yml
@@ -37,5 +37,5 @@ jobs:
projects: clang
# There is an issue running on "windows-2019".
# See https://github.com/llvm/llvm-project/issues/76601#issuecomment-1873049082.
- os_list: '["ubuntu-22.04"]'
+ os_list: '["ubuntu-24.04"]'
python_version: ${{ matrix.python-version }}
diff --git a/.github/workflows/llvm-project-tests.yml b/.github/workflows/llvm-project-tests.yml
index 3da6743c49e25..d40ed5babb459 100644
--- a/.github/workflows/llvm-project-tests.yml
+++ b/.github/workflows/llvm-project-tests.yml
@@ -39,12 +39,7 @@ on:
type: string
# Use windows-2019 due to:
# https://developercommunity.visualstudio.com/t/Prev-Issue---with-__assume-isnan-/1597317
- # Use ubuntu-22.04 rather than ubuntu-24.04 to match the ubuntu
- # version in the CI container. Without this, setup-python tries
- # to install a python version linked against a newer version of glibc.
- # TODO(boomanaiden154): Bump the Ubuntu version once the version in the
- # container is bumped.
- default: '["ubuntu-22.04", "windows-2019", "macOS-13"]'
+ default: '["ubuntu-24.04", "windows-2019", "macOS-13"]'
python_version:
required: false
@@ -64,7 +59,7 @@ jobs:
name: Lit Tests
runs-on: ${{ matrix.os }}
container:
- image: ${{(startsWith(matrix.os, 'ubuntu') && 'ghcr.io/llvm/ci-ubuntu-22.04:latest') || null}}
+ image: ${{(startsWith(matrix.os, 'ubuntu') && 'ghcr.io/llvm/ci-ubuntu-24.04:latest') || null}}
volumes:
- /mnt/:/mnt/
strategy:
diff --git a/.github/workflows/spirv-tests.yml b/.github/workflows/spirv-tests.yml
index ea466dc6c52e5..f15ca1cb64ba5 100644
--- a/.github/workflows/spirv-tests.yml
+++ b/.github/workflows/spirv-tests.yml
@@ -26,4 +26,4 @@ jobs:
build_target: check-llvm-codegen-spirv
projects:
extra_cmake_args: '-DLLVM_TARGETS_TO_BUILD="SPIRV" -DLLVM_INCLUDE_SPIRV_TOOLS_TESTS=ON'
- os_list: '["ubuntu-22.04"]'
+ os_list: '["ubuntu-24.04"]'
|
tstellar
approved these changes
Apr 10, 2025
var-const
pushed a commit
to ldionne/llvm-project
that referenced
this pull request
Apr 17, 2025
…vm#133626) This patch bumps workflows depending upon the Linux CI container to ubuntu 24.04. The 22.04 container is no longer being built as it was recently bumped to 24.04, so this patch moves all of these workflows over to the new container to keep them updated and ensure they are using an actually maintained version of the container image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch bumps workflows depending upon the Linux CI container to ubuntu 24.04. The 22.04 container is no longer being built as it was recently bumped to 24.04, so this patch moves all of these workflows over to the new container to keep them updated and ensure they are using an actually maintained version of the container image.