InlineCostAnnotationPrinter: Fix constructing random TargetTransformInfo #133637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Query the correct TTI for the current target instead of constructing some random default one. Also query the pass manager for ProfileSummaryInfo.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
llvmbot
added
the
llvm:analysis
arsenm
commented
Mar 30, 2025
|
@llvm/pr-subscribers-llvm-analysis Author: Matt Arsenault (arsenm) ChangesQuery the correct TTI for the current target instead of constructing Full diff: https://github.com/llvm/llvm-project/pull/133637.diff 1 Files Affected:
diff --git a/llvm/lib/Analysis/InlineCost.cpp b/llvm/lib/Analysis/InlineCost.cpp
index e42b2bd82cf2e..9f193b610328b 100644
--- a/llvm/lib/Analysis/InlineCost.cpp
+++ b/llvm/lib/Analysis/InlineCost.cpp
@@ -3295,9 +3295,12 @@ InlineCostAnnotationPrinterPass::run(Function &F,
[&](Function &F) -> AssumptionCache & {
return FAM.getResult<AssumptionAnalysis>(F);
};
- Module *M = F.getParent();
- ProfileSummaryInfo PSI(*M);
- TargetTransformInfo TTI(M->getDataLayout());
+
+ auto &MAMProxy = FAM.getResult<ModuleAnalysisManagerFunctionProxy>(F);
+ ProfileSummaryInfo *PSI =
+ MAMProxy.getCachedResult<ProfileSummaryAnalysis>(*F.getParent());
+ const TargetTransformInfo &TTI = FAM.getResult<TargetIRAnalysis>(F);
+
// FIXME: Redesign the usage of InlineParams to expand the scope of this pass.
// In the current implementation, the type of InlineParams doesn't matter as
// the pass serves only for verification of inliner's decisions.
@@ -3312,7 +3315,7 @@ InlineCostAnnotationPrinterPass::run(Function &F,
continue;
OptimizationRemarkEmitter ORE(CalledFunction);
InlineCostCallAnalyzer ICCA(*CalledFunction, *CB, Params, TTI,
- GetAssumptionCache, nullptr, nullptr, &PSI,
+ GetAssumptionCache, nullptr, nullptr, PSI,
&ORE);
ICCA.analyze();
OS << " Analyzing call of " << CalledFunction->getName()
|
mtrofin
approved these changes
Mar 30, 2025
arsenm
changed the title
arsenm
deleted the
users/arsenm/inline-cost/fix-constructing-tti-for-no-reason
branch
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/198/builds/3270 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/23/builds/8918 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/199/builds/2472 Here is the relevant piece of the build log for the reference |
SchrodingerZhu
pushed a commit
to SchrodingerZhu/llvm-project
that referenced
this pull request
Mar 31, 2025
…nfo (llvm#133637) Query the correct TTI for the current target instead of constructing some random default one. Also query the pass manager for ProfileSummaryInfo. This should only change the printing, not the actual result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query the correct TTI for the current target instead of constructing
some random default one. Also query the pass manager for ProfileSummaryInfo.
This should only change the printing, not the actual result.