Skip to content

llvm-reduce: Use 80 dashes for section separator in status printing #133686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

arsenm
Copy link
Contributor

@arsenm arsenm commented Mar 31, 2025

Previously it printed a shorter sequence of dashes, which were shorter
than most of the printed pass descriptions. It is much shorter than
the printed names after fea6b38.
Make this look more consistent by filling a standard terminal width.

Previously it printed a shorter sequence of dashes, which were shorter
than most of the printed pass descriptions. It is much shorter than
the printed names after fea6b38.
Make this look more consistent by filling a standard terminal width.
Copy link
Contributor Author

arsenm commented Mar 31, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@arsenm arsenm requested review from aeubanks, fhahn and regehr March 31, 2025 07:05
@arsenm arsenm marked this pull request as ready for review March 31, 2025 07:05
@arsenm arsenm merged commit f82283a into main Mar 31, 2025
15 checks passed
@arsenm arsenm deleted the users/arsenm/llvm-reduce/use-80-column-line-separator branch March 31, 2025 11:06
@llvm-ci
Copy link
Collaborator

llvm-ci commented Mar 31, 2025

LLVM Buildbot has detected a new failure on builder lldb-aarch64-ubuntu running on linaro-lldb-aarch64-ubuntu while building llvm at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/15179

Here is the relevant piece of the build log for the reference
Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: functionalities/conditional_break/TestConditionalBreak.py (325 of 2110)
UNSUPPORTED: lldb-api :: functionalities/data-formatter/compactvectors/TestCompactVectors.py (326 of 2110)
PASS: lldb-api :: functionalities/data-formatter/cstring-utf8-summary/TestCstringUnicode.py (327 of 2110)
PASS: lldb-api :: functionalities/data-formatter/builtin-formats/TestBuiltinFormats.py (328 of 2110)
PASS: lldb-api :: functionalities/breakpoint/consecutive_breakpoints/TestConsecutiveBreakpoints.py (329 of 2110)
PASS: lldb-api :: functionalities/data-formatter/callback-matching/TestDataFormatterCallbackMatching.py (330 of 2110)
PASS: lldb-api :: functionalities/breakpoint/thread_plan_user_breakpoint/TestThreadPlanUserBreakpoint.py (331 of 2110)
PASS: lldb-api :: functionalities/data-formatter/data-formatter-caching/TestDataFormatterCaching.py (332 of 2110)
PASS: lldb-api :: functionalities/data-formatter/custom-printf-summary/TestCustomSummaryLLVMFormat.py (333 of 2110)
PASS: lldb-api :: functionalities/data-formatter/data-formatter-categories/TestDataFormatterCategories.py (334 of 2110)
FAIL: lldb-api :: functionalities/data-formatter/data-formatter-advanced/TestDataFormatterAdv.py (335 of 2110)
******************** TEST 'lldb-api :: functionalities/data-formatter/data-formatter-advanced/TestDataFormatterAdv.py' FAILED ********************
Script:
--
/usr/bin/python3.10 /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib --env LLVM_INCLUDE_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/include --env LLVM_TOOLS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --arch aarch64 --build-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex --lldb-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/lldb --compiler /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/clang --dsymutil /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/dsymutil --make /usr/bin/gmake --llvm-tools-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --lldb-obj-root /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb --lldb-libs-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/functionalities/data-formatter/data-formatter-advanced -p TestDataFormatterAdv.py
--
Exit Code: -11

Command Output (stdout):
--
lldb version 21.0.0git (https://github.com/llvm/llvm-project.git revision f82283a84ed897f06a1aaac028accbad0d5057c7)
  clang revision f82283a84ed897f06a1aaac028accbad0d5057c7
  llvm revision f82283a84ed897f06a1aaac028accbad0d5057c7
Skipping the following test categories: ['libc++', 'dsym', 'gmodules', 'debugserver', 'objc']

--
Command Output (stderr):
--
UNSUPPORTED: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test_with_run_command_dsym (TestDataFormatterAdv.AdvDataFormatterTestCase) (test case does not fall in any category of interest for this run) 
PASS: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test_with_run_command_dwarf (TestDataFormatterAdv.AdvDataFormatterTestCase)
PASS: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test_with_run_command_dwo (TestDataFormatterAdv.AdvDataFormatterTestCase)
----------------------------------------------------------------------
Ran 3 tests in 0.976s

OK (skipped=1)

--

********************
UNSUPPORTED: lldb-api :: functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCCF.py (336 of 2110)
PASS: lldb-api :: functionalities/data-formatter/data-formatter-globals/TestDataFormatterGlobals.py (337 of 2110)
PASS: lldb-api :: functionalities/data-formatter/data-formatter-enum-format/TestDataFormatterEnumFormat.py (338 of 2110)
PASS: lldb-api :: functionalities/data-formatter/data-formatter-disabling/TestDataFormatterDisabling.py (339 of 2110)
UNSUPPORTED: lldb-api :: functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCExpr.py (340 of 2110)
UNSUPPORTED: lldb-api :: functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCKVO.py (341 of 2110)
PASS: lldb-api :: functionalities/data-formatter/data-formatter-named-summaries/TestDataFormatterNamedSummaries.py (342 of 2110)
PASS: lldb-api :: functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py (343 of 2110)
UNSUPPORTED: lldb-api :: functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSContainer.py (344 of 2110)
UNSUPPORTED: lldb-api :: functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjCNSBundle.py (345 of 2110)

SchrodingerZhu pushed a commit to SchrodingerZhu/llvm-project that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants