Skip to content

[WebAssembly] Add a missing break statement #133783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

alexcrichton
Copy link
Contributor

This fixes an issue introduced in #132430 where a break; statement was accidentally missing causing unintended fall-through.

This fixes an issue introduced in llvm#132430 where a `break;` statement was
accidentally missing causing unintended fall-through.
@llvmbot
Copy link
Member

llvmbot commented Mar 31, 2025

@llvm/pr-subscribers-backend-webassembly

Author: Alex Crichton (alexcrichton)

Changes

This fixes an issue introduced in #132430 where a break; statement was accidentally missing causing unintended fall-through.


Full diff: https://github.com/llvm/llvm-project/pull/133783.diff

1 Files Affected:

  • (modified) llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp (+1)
diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp b/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
index 82d3b8e292e60..794db887bd073 100644
--- a/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
+++ b/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
@@ -1109,6 +1109,7 @@ void WebAssemblyTargetLowering::computeKnownBitsForTargetNode(
       break;
     }
     }
+    break;
   }
 
   // For 128-bit addition if the upper bits are all zero then it's known that

@amykhuang amykhuang merged commit c632466 into llvm:main Mar 31, 2025
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants