Skip to content

[lldb-dap] Enable runInTerminal tests on macOS. #133824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

[lldb-dap] Enable runInTerminal tests on macOS. #133824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lldb/test/API/tools/lldb-dap/restart/TestDAP_restart_runInTerminal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def isTestSupported(self):
return False

@skipIfWindows
@skipIf(archs=["arm"]) # Always times out on buildbot
@skipIf(oslist=["linux"], archs=["arm"]) # Always times out on buildbot
def test_basic_functionality(self):
"""
Test basic restarting functionality when the process is running in
Expand Down Expand Up @@ -61,7 +61,7 @@ def test_basic_functionality(self):
)

@skipIfWindows
@skipIf(archs=["arm"]) # Always times out on buildbot
@skipIf(oslist=["linux"], archs=["arm"]) # Always times out on buildbot
def test_stopOnEntry(self):
"""
Check that stopOnEntry works correctly when using runInTerminal.
Expand Down
16 changes: 8 additions & 8 deletions lldb/test/API/tools/lldb-dap/runInTerminal/TestDAP_runInTerminal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def isTestSupported(self):
return False

@skipIfWindows
@skipIf(archs=no_match(["x86_64"]))
@skipIf(oslist=["linux"], archs=no_match(["x86_64"]))
def test_runInTerminal(self):
if not self.isTestSupported():
return
Expand Down Expand Up @@ -90,7 +90,7 @@ def test_runInTerminal(self):
env = self.dap_server.request_evaluate("foo")["body"]["result"]
self.assertIn("bar", env)

@skipIf(archs=no_match(["x86_64"]))
@skipIf(oslist=["linux"], archs=no_match(["x86_64"]))
def test_runInTerminalWithObjectEnv(self):
if not self.isTestSupported():
return
Expand All @@ -114,7 +114,7 @@ def test_runInTerminalWithObjectEnv(self):
self.assertEqual("BAR", request_envs["FOO"])

@skipIfWindows
@skipIf(archs=no_match(["x86_64"]))
@skipIf(oslist=["linux"], archs=no_match(["x86_64"]))
def test_runInTerminalInvalidTarget(self):
if not self.isTestSupported():
return
Expand All @@ -133,7 +133,7 @@ def test_runInTerminalInvalidTarget(self):
)

@skipIfWindows
@skipIf(archs=no_match(["x86_64"]))
@skipIf(oslist=["linux"], archs=no_match(["x86_64"]))
def test_missingArgInRunInTerminalLauncher(self):
if not self.isTestSupported():
return
Expand All @@ -148,7 +148,7 @@ def test_missingArgInRunInTerminalLauncher(self):
)

@skipIfWindows
@skipIf(archs=no_match(["x86_64"]))
@skipIf(oslist=["linux"], archs=no_match(["x86_64"]))
def test_FakeAttachedRunInTerminalLauncherWithInvalidProgram(self):
if not self.isTestSupported():
return
Expand All @@ -175,7 +175,7 @@ def test_FakeAttachedRunInTerminalLauncherWithInvalidProgram(self):
self.assertIn("No such file or directory", stderr)

@skipIfWindows
@skipIf(archs=no_match(["x86_64"]))
@skipIf(oslist=["linux"], archs=no_match(["x86_64"]))
def test_FakeAttachedRunInTerminalLauncherWithValidProgram(self):
if not self.isTestSupported():
return
Expand All @@ -202,7 +202,7 @@ def test_FakeAttachedRunInTerminalLauncherWithValidProgram(self):
self.assertIn("foo", stdout)

@skipIfWindows
@skipIf(archs=no_match(["x86_64"]))
@skipIf(oslist=["linux"], archs=no_match(["x86_64"]))
def test_FakeAttachedRunInTerminalLauncherAndCheckEnvironment(self):
if not self.isTestSupported():
return
Expand All @@ -223,7 +223,7 @@ def test_FakeAttachedRunInTerminalLauncherAndCheckEnvironment(self):
self.assertIn("FOO=BAR", stdout)

@skipIfWindows
@skipIf(archs=no_match(["x86_64"]))
@skipIf(oslist=["linux"], archs=no_match(["x86_64"]))
def test_NonAttachedRunInTerminalLauncher(self):
if not self.isTestSupported():
return
Expand Down