llvm-reduce: Do not delete convergencectrl in operand-bundles #133858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IR verifier will fail if there are any convergent calls without a convergencectrl bundle, if there are any convergencectrl bundles. With the current verifier rules, we would need to drop all the instances of convergencectrl in the function as a set, and strip all the convergence token intrinsics. As such, I think it would be more appropriate to have a separate convergence reduction pass.
tgymnich
approved these changes
Apr 1, 2025
aeubanks
approved these changes
Apr 1, 2025
|
LGTM |
arsenm
deleted the
users/arsenm/llvm-reduce/ignore-convergencectrl-operand-bundles
branch
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
Apr 2, 2025
…33858) The IR verifier will fail if there are any convergent calls without a convergencectrl bundle, if there are any convergencectrl bundles. With the current verifier rules, we would need to drop all the instances of convergencectrl in the function as a set, and strip all the convergence token intrinsics. As such, I think it would be more appropriate to have a separate convergence reduction pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IR verifier will fail if there are any convergent calls without
a convergencectrl bundle, if there are any convergencectrl bundles.
With the current verifier rules, we would need to drop all the instances
of convergencectrl in the function as a set, and strip all the convergence
token intrinsics. As such, I think it would be more appropriate to have a
separate convergence reduction pass.