Skip to content

[sanitizer_common][NFC] Fix sanitizer_symbolizer_libcdep.cpp formatting #133930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2025
Merged

[sanitizer_common][NFC] Fix sanitizer_symbolizer_libcdep.cpp formatting #133930

merged 2 commits into from
Apr 3, 2025

Conversation

jakeegan
Copy link
Member

@jakeegan jakeegan commented Apr 1, 2025

No description provided.

@jakeegan jakeegan mentioned this pull request Apr 1, 2025
Open
hubert-reinterpretcast
hubert-reinterpretcast reviewed Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@hubert-reinterpretcast hubert-reinterpretcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is at least one "sibling" preprocessor conditional that is not indented the same way at

llvm-project/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_libcdep.cpp

Line 223 in 17cef53

#if !SANITIZER_INTERCEPT_DLOPEN_DLCLOSE
.

Perhaps the patch should just clang-format the entire file?

@jakeegan jakeegan changed the title [sanitizer_common][NFC] Fix some preprocessor directive formatting [sanitizer_common][NFC] Fix sanitizer_symbolizer_libcdep.cpp formatting Apr 1, 2025
hubert-reinterpretcast
hubert-reinterpretcast approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@hubert-reinterpretcast hubert-reinterpretcast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jakeegan jakeegan merged commit 50fe5b9 into llvm:main Apr 3, 2025
10 checks passed
@jakeegan jakeegan deleted the sanitizer_symbolizer_libcdep_formatting branch April 3, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubert-reinterpretcast hubert-reinterpretcast hubert-reinterpretcast approved these changes

@vitalybuka vitalybuka Awaiting requested review from vitalybuka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakeegan @hubert-reinterpretcast