[libclc] Move exp, exp2 and expm1 to the CLC library #133932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These all share the use of a common helper function so are handled in one go. These builtins are also now vectorized.
arsenm
approved these changes
Apr 1, 2025
| const __CLC_GENTYPE llim = -126.0f; | ||
|
|
||
| r = x < llim ? 0.0f : r; | ||
| r = x < ulim ? r : __CLC_AS_FLOATN((__CLC_UINTN)0x7f800000); |
There was a problem hiding this comment.
Should just use infinity as a later cleanup
There was a problem hiding this comment.
Yes, there's good opportunity for infinity-related improvements.
Ankur-0429
pushed a commit
to Ankur-0429/llvm-project
that referenced
this pull request
Apr 2, 2025
These all share the use of a common helper function so are handled in one go. These builtins are also now vectorized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These all share the use of a common helper function so are handled in one go. These builtins are also now vectorized.