llvm-reduce: Change exit code for uninteresting inputs

[arsenm]

This makes it easier to reduce llvm-reduce with llvm-reduce to filter
cases where the input reduced too much.

Not sure if it's possible to test the exit code in lit.

[arsenm]

• llvm-reduce: Change exit code for uninteresting inputs #134021 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[llvmbot]

@llvm/pr-subscribers-llvm-binary-utilities

Author: Matt Arsenault (arsenm)

Changes

This makes it easier to reduce llvm-reduce with llvm-reduce to filter
cases where the input reduced too much.

Not sure if it's possible to test the exit code in lit.

---

Full diff: https://github.com/llvm/llvm-project/pull/134021.diff

2 Files Affected:

• (modified) llvm/docs/CommandGuide/llvm-reduce.rst (+3-2)
• (modified) llvm/tools/llvm-reduce/llvm-reduce.cpp (+1-1)

diff --git a/llvm/docs/CommandGuide/llvm-reduce.rst b/llvm/docs/CommandGuide/llvm-reduce.rst
index 2670668af6cca..85111e6e29443 100644
--- a/llvm/docs/CommandGuide/llvm-reduce.rst
+++ b/llvm/docs/CommandGuide/llvm-reduce.rst
@@ -108,8 +108,9 @@ GENERIC OPTIONS
 EXIT STATUS
 ------------
 
-:program:`llvm-reduce` returns 0 under normal operation. It returns a non-zero
-exit code if there were any errors.
+:program:`llvm-reduce` returns 0 under normal operation. It returns a
+non-zero exit code if there were any errors. Returns 2 if the
+interestingness test reported the initial input was not interesting.
 
 EXAMPLE
 -------
diff --git a/llvm/tools/llvm-reduce/llvm-reduce.cpp b/llvm/tools/llvm-reduce/llvm-reduce.cpp
index 288a384c2ed49..f7492988084ce 100644
--- a/llvm/tools/llvm-reduce/llvm-reduce.cpp
+++ b/llvm/tools/llvm-reduce/llvm-reduce.cpp
@@ -203,7 +203,7 @@ int main(int Argc, char **Argv) {
   // interestingness checks.
   if (!Tester.getProgram().isReduced(Tester)) {
     errs() << "\nInput isn't interesting! Verify interesting-ness test\n";
-    return 1;
+    return 2;
   }
 
   // Try to reduce code

[arsenm]

Merge activity

• Apr 2, 12:41 PM EDT: A user started a stack merge that includes this pull request via Graphite.
• Apr 2, 12:43 PM EDT: A user merged this pull request with Graphite.

[fhahn]

LGTM, thanks!

[fhahn]

If we document the return codes, should we also say something about the other return codes (basically 1 for all other errors?)