Skip to content

[X86] getFauxShuffleMask - move INSERT_SUBVECTOR(SRC0, EXTRACT_SUBVECTOR(SRC1)) matching behind common one use bitcast checks #134227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged

[X86] getFauxShuffleMask - move INSERT_SUBVECTOR(SRC0, EXTRACT_SUBVECTOR(SRC1)) matching behind common one use bitcast checks #134227

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25e806f
[X86] getFauxShuffleMask - move INSERT_SUBVECTOR(SRC0, EXTRACT_SUBVEC…
RKSimon Apr 3, 2025
656ebdf
clang-format
RKSimon Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 22 additions & 19 deletions llvm/lib/Target/X86/X86ISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6185,18 +6185,26 @@ static bool getFauxShuffleMask(SDValue N, const APInt &DemandedElts,
}
if (!N->isOnlyUserOf(Sub.getNode()))
return false;
SDValue SubBC = peekThroughBitcasts(Sub);

SmallVector<int, 64> SubMask;
SmallVector<SDValue, 2> SubInputs;
SDValue SubSrc = peekThroughOneUseBitcasts(Sub);
EVT SubSrcVT = SubSrc.getValueType();
if (!SubSrcVT.isVector())
return false;

// Handle INSERT_SUBVECTOR(SRC0, EXTRACT_SUBVECTOR(SRC1)).
if (SubBC.getOpcode() == ISD::EXTRACT_SUBVECTOR &&
SubBC.getOperand(0).getValueSizeInBits() == NumSizeInBits) {
uint64_t ExtractIdx = SubBC.getConstantOperandVal(1);
SDValue SubBCSrc = SubBC.getOperand(0);
unsigned NumSubSrcBCElts = SubBCSrc.getValueType().getVectorNumElements();
unsigned MaxElts = std::max(NumElts, NumSubSrcBCElts);
assert((MaxElts % NumElts) == 0 && (MaxElts % NumSubSrcBCElts) == 0 &&
if (SubSrc.getOpcode() == ISD::EXTRACT_SUBVECTOR &&
SubSrc.getOperand(0).getValueSizeInBits() == NumSizeInBits) {
uint64_t ExtractIdx = SubSrc.getConstantOperandVal(1);
SDValue SubSrcSrc = SubSrc.getOperand(0);
unsigned NumSubSrcSrcElts =
SubSrcSrc.getValueType().getVectorNumElements();
unsigned MaxElts = std::max(NumElts, NumSubSrcSrcElts);
assert((MaxElts % NumElts) == 0 && (MaxElts % NumSubSrcSrcElts) == 0 &&
"Subvector valuetype mismatch");
InsertIdx *= (MaxElts / NumElts);
ExtractIdx *= (MaxElts / NumSubSrcBCElts);
ExtractIdx *= (MaxElts / NumSubSrcSrcElts);
NumSubElts *= (MaxElts / NumElts);
bool SrcIsUndef = Src.isUndef();
for (int i = 0; i != (int)MaxElts; ++i)
Expand All @@ -6205,17 +6213,11 @@ static bool getFauxShuffleMask(SDValue N, const APInt &DemandedElts,
Mask[InsertIdx + i] = (SrcIsUndef ? 0 : MaxElts) + ExtractIdx + i;
if (!SrcIsUndef)
Ops.push_back(Src);
Ops.push_back(SubBCSrc);
Ops.push_back(SubSrcSrc);
return true;
}
// Handle INSERT_SUBVECTOR(SRC0, SHUFFLE(SRC1)).
SmallVector<int, 64> SubMask;
SmallVector<SDValue, 2> SubInputs;
SDValue SubSrc = peekThroughOneUseBitcasts(Sub);
EVT SubSrcVT = SubSrc.getValueType();
if (!SubSrcVT.isVector())
return false;

// Handle INSERT_SUBVECTOR(SRC0, SHUFFLE(SRC1)).
APInt SubDemand = APInt::getAllOnes(SubSrcVT.getVectorNumElements());
if (!getTargetShuffleInputs(SubSrc, SubDemand, SubInputs, SubMask, DAG,
Depth + 1, ResolveKnownElts))
Expand All @@ -6230,10 +6232,11 @@ static bool getFauxShuffleMask(SDValue N, const APInt &DemandedElts,

if (SubMask.size() != NumSubElts) {
assert(((SubMask.size() % NumSubElts) == 0 ||
(NumSubElts % SubMask.size()) == 0) && "Illegal submask scale");
(NumSubElts % SubMask.size()) == 0) &&
"Illegal submask scale");
if ((NumSubElts % SubMask.size()) == 0) {
int Scale = NumSubElts / SubMask.size();
SmallVector<int,64> ScaledSubMask;
SmallVector<int, 64> ScaledSubMask;
narrowShuffleMaskElts(Scale, SubMask, ScaledSubMask);
SubMask = ScaledSubMask;
} else {
Expand Down
Loading