[clang][deps] Avoid unchecked error assertion

[jansvoboda11]

No description provided.

[Copilot]

Pull Request Overview

This PR modifies the error reporting when opening an output file in clang-scan-deps to avoid using unchecked error assertions.

• Replace conversion of errno with llvm::errorCodeToError(EC) to using EC.message() for error output.

Comments suppressed due to low confidence (1)

clang/tools/clang-scan-deps/ClangScanDeps.cpp:931

• Consider verifying that EC.message() provides sufficient context compared to llvm::errorCodeToError(EC) to ensure that users receive clear diagnostic information if the output file fails to open.

llvm::errs() << "Failed to open output file '" << OutputFileName << "': " << EC.message() << '\n';

[llvmbot]

@llvm/pr-subscribers-clang

Author: Jan Svoboda (jansvoboda11)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/134284.diff

1 Files Affected:

• (modified) clang/tools/clang-scan-deps/ClangScanDeps.cpp (+1-1)

diff --git a/clang/tools/clang-scan-deps/ClangScanDeps.cpp b/clang/tools/clang-scan-deps/ClangScanDeps.cpp
index fa63649bb9028..13dab6e445733 100644
--- a/clang/tools/clang-scan-deps/ClangScanDeps.cpp
+++ b/clang/tools/clang-scan-deps/ClangScanDeps.cpp
@@ -929,7 +929,7 @@ int clang_scan_deps_main(int argc, char **argv, const llvm::ToolContext &) {
     FileOS.emplace(OutputFileName, EC, llvm::sys::fs::OF_Text);
     if (EC) {
       llvm::errs() << "Failed to open output file '" << OutputFileName
-                   << "': " << llvm::errorCodeToError(EC) << '\n';
+                   << "': " << EC.message() << '\n';
       std::exit(1);
     }
     return *FileOS;