[bazel] Fold "${Target}Analysis" targets into their respective CodeGen targets. #134312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n targets. After 3801bf6, SPIRVAnalysis needs to include SPIRV.h provided by SPIRVCodegen, but the CodeGen target already depends on Analysis, so that would cause a circular dependency. Analysis is a subdirectory of CodeGen so it makes sense as a part of the main CodeGen target too.
jyknight
changed the title
jyknight
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 3801bf6, SPIRVAnalysis needs to include SPIRV.h provided by SPIRVCodegen, but the CodeGen target already depends on Analysis, so that would cause a circular dependency.
Analysis is a subdirectory of CodeGen so it makes sense as a part of the main CodeGen target too.