Skip to content

[ctxprof] Move MoveSymbolGUID to address dependency issues #134334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

[ctxprof] Move MoveSymbolGUID to address dependency issues #134334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions llvm/lib/Transforms/IPO/FunctionImport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,14 +182,7 @@ static cl::opt<bool> CtxprofMoveRootsToOwnModule(
"their own module."),
cl::Hidden, cl::init(false));

cl::list<GlobalValue::GUID> MoveSymbolGUID(
"thinlto-move-symbols",
cl::desc(
"Move the symbols with the given name. This will delete these symbols "
"wherever they are originally defined, and make sure their "
"linkage is External where they are imported. It is meant to be "
"used with the name of contextual profiling roots."),
cl::Hidden);
extern cl::list<GlobalValue::GUID> MoveSymbolGUID;

namespace llvm {
extern cl::opt<bool> EnableMemProfContextDisambiguation;
Expand Down
9 changes: 8 additions & 1 deletion llvm/lib/Transforms/Utils/FunctionImportUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,14 @@ static cl::opt<bool> UseSourceFilenameForPromotedLocals(
"This requires that the source filename has a unique name / "
"path to avoid name collisions."));

extern cl::list<GlobalValue::GUID> MoveSymbolGUID;
cl::list<GlobalValue::GUID> MoveSymbolGUID(
"thinlto-move-symbols",
cl::desc(
"Move the symbols with the given name. This will delete these symbols "
"wherever they are originally defined, and make sure their "
"linkage is External where they are imported. It is meant to be "
"used with the name of contextual profiling roots."),
cl::Hidden);

FunctionImportGlobalProcessing::FunctionImportGlobalProcessing(
Module &M, const ModuleSummaryIndex &Index,
Expand Down
Loading