Skip to content

Revert "[LLDB] Expose checking if the symbol file exists/is loaded via SBModule" #134341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

Jlalond
Copy link
Contributor

@Jlalond Jlalond commented Apr 4, 2025

Reverts #134163

Reverting while @clayborg and I come up with a better API

@Jlalond Jlalond requested a review from JDevlieghere as a code owner April 4, 2025 03:45
@Jlalond Jlalond merged commit 8e7d6ba into main Apr 4, 2025
4 of 5 checks passed
@Jlalond Jlalond deleted the revert-134163-sbmodule-symbolfile-loaded branch April 4, 2025 03:45
@llvmbot llvmbot added the lldb label Apr 4, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 4, 2025

@llvm/pr-subscribers-lldb

Author: Jacob Lalonde (Jlalond)

Changes

Reverts llvm/llvm-project#134163

Reverting while @clayborg and I come up with a better API


Full diff: https://github.com/llvm/llvm-project/pull/134341.diff

2 Files Affected:

  • (modified) lldb/include/lldb/API/SBModule.h (-3)
  • (modified) lldb/source/API/SBModule.cpp (-12)
diff --git a/lldb/include/lldb/API/SBModule.h b/lldb/include/lldb/API/SBModule.h
index 651455bdb78d2..85332066ee687 100644
--- a/lldb/include/lldb/API/SBModule.h
+++ b/lldb/include/lldb/API/SBModule.h
@@ -290,9 +290,6 @@ class LLDB_API SBModule {
   lldb::SBAddress GetObjectFileHeaderAddress() const;
   lldb::SBAddress GetObjectFileEntryPointAddress() const;
 
-  /// Get if the symbol file for this module is loaded.
-  bool IsDebugInfoLoaded() const;
-
   /// Get the number of global modules.
   static uint32_t GetNumberAllocatedModules();
 
diff --git a/lldb/source/API/SBModule.cpp b/lldb/source/API/SBModule.cpp
index 4978a553f57c7..985107ec68efd 100644
--- a/lldb/source/API/SBModule.cpp
+++ b/lldb/source/API/SBModule.cpp
@@ -659,18 +659,6 @@ lldb::SBAddress SBModule::GetObjectFileEntryPointAddress() const {
   return sb_addr;
 }
 
-bool SBModule::IsDebugInfoLoaded() const {
-  LLDB_INSTRUMENT_VA(this);
-
-  ModuleSP module_sp(GetSP());
-  if (module_sp) {
-    SymbolFile *sym_file = module_sp->GetSymbolFile(/*create=*/false);
-    return sym_file && sym_file->GetLoadDebugInfoEnabled();
-  }
-
-  return false;
-}
-
 uint32_t SBModule::GetNumberAllocatedModules() {
   LLDB_INSTRUMENT();
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants