[clang][test] Improve unit tests for Fixed point AST matchers. #134398
+82
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang Author: None (earnol) ChangesWe have AST matchers for fixed point float numbers since commits 789215d and Full diff: https://github.com/llvm/llvm-project/pull/134398.diff 2 Files Affected:
diff --git a/clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp b/clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp
index 680e21840b7d3..60d0bbf42cf23 100644
--- a/clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp
+++ b/clang/unittests/ASTMatchers/ASTMatchersNodeTest.cpp
@@ -1017,6 +1017,49 @@ TEST_P(ASTMatchersTest, FloatLiteral) {
notMatches("double i = 5.0;", floatLiteral(equals(llvm::APFloat(6.0)))));
}
+TEST_P(ASTMatchersTest, FixedPointLiterals) {
+ StatementMatcher HasFixedPointLiteral = fixedPointLiteral();
+ EXPECT_TRUE(matchesWithFixedpoint("_Fract i = 0.25r;", HasFixedPointLiteral));
+ EXPECT_TRUE(
+ matchesWithFixedpoint("_Fract i = 0.25hr;", HasFixedPointLiteral));
+ EXPECT_TRUE(
+ matchesWithFixedpoint("_Fract i = 0.25uhr;", HasFixedPointLiteral));
+ EXPECT_TRUE(
+ matchesWithFixedpoint("_Fract i = 0.25ur;", HasFixedPointLiteral));
+ EXPECT_TRUE(
+ matchesWithFixedpoint("_Fract i = 0.25lr;", HasFixedPointLiteral));
+ EXPECT_TRUE(
+ matchesWithFixedpoint("_Fract i = 0.25ulr;", HasFixedPointLiteral));
+ EXPECT_TRUE(matchesWithFixedpoint("_Accum i = 1.25k;", HasFixedPointLiteral));
+ EXPECT_TRUE(
+ matchesWithFixedpoint("_Accum i = 1.25hk;", HasFixedPointLiteral));
+ EXPECT_TRUE(
+ matchesWithFixedpoint("_Accum i = 1.25uhk;", HasFixedPointLiteral));
+ EXPECT_TRUE(
+ matchesWithFixedpoint("_Accum i = 1.25uk;", HasFixedPointLiteral));
+ EXPECT_TRUE(
+ matchesWithFixedpoint("_Accum i = 1.25lk;", HasFixedPointLiteral));
+ EXPECT_TRUE(
+ matchesWithFixedpoint("_Accum i = 1.25ulk;", HasFixedPointLiteral));
+ EXPECT_TRUE(matchesWithFixedpoint("_Accum decexp1 = 1.575e1k;",
+ HasFixedPointLiteral));
+ EXPECT_TRUE(
+ matchesWithFixedpoint("_Accum hex = 0x1.25fp2k;", HasFixedPointLiteral));
+ EXPECT_TRUE(matchesWithFixedpoint("_Sat long _Fract i = 0.25r;",
+ HasFixedPointLiteral));
+ EXPECT_TRUE(matchesWithFixedpoint("_Sat short _Accum i = 256.0k;",
+ HasFixedPointLiteral));
+
+ EXPECT_TRUE(
+ notMatchesWithFixedpoint("short _Accum i = 2u;", HasFixedPointLiteral));
+ EXPECT_TRUE(
+ notMatchesWithFixedpoint("short _Accum i = 2;", HasFixedPointLiteral));
+ EXPECT_TRUE(
+ notMatchesWithFixedpoint("_Accum i = 1.25;", HasFixedPointLiteral));
+ EXPECT_TRUE(notMatchesWithFixedpoint("_Accum i = 1.25 * 4.5i;",
+ HasFixedPointLiteral));
+}
+
TEST_P(ASTMatchersTest, CXXNullPtrLiteralExpr) {
if (!GetParam().isCXX11OrLater()) {
return;
diff --git a/clang/unittests/ASTMatchers/ASTMatchersTest.h b/clang/unittests/ASTMatchers/ASTMatchersTest.h
index ad2f5f355621c..5f8bdf7ecc621 100644
--- a/clang/unittests/ASTMatchers/ASTMatchersTest.h
+++ b/clang/unittests/ASTMatchers/ASTMatchersTest.h
@@ -289,6 +289,17 @@ testing::AssertionResult notMatchesWithOpenMP51(const Twine &Code,
{"-fopenmp=libomp", "-fopenmp-version=51"});
}
+template <typename T>
+testing::AssertionResult matchesWithFixedpoint(const std::string &Code,
+ const T &AMatcher) {
+ return matchesConditionally(Code, AMatcher, true, "-ffixed-point", FileContentMappings(), "input.c");
+}
+template <typename T>
+testing::AssertionResult notMatchesWithFixedpoint(const std::string &Code,
+ const T &AMatcher) {
+ return matchesConditionally(Code, AMatcher, false, "-ffixed-point", FileContentMappings(), "input.c");
+}
+
template <typename T>
testing::AssertionResult matchAndVerifyResultConditionally(
const Twine &Code, const T &AMatcher,
|
earnol
force-pushed
the
main
branch
4 times, most recently
from
203d77b to
655a39e
Compare
llvmbot
added
the
clang:frontend
earnol
requested review from
a-tarasyuk,
alexander-shaposhnikov,
AlexeySotkin,
PiotrZSL,
EugeneZelenko and
HerrCai0907
|
Gentle ping! Requesting a review from the community, since a week had passed with no response. |
a-tarasyuk
approved these changes
Apr 14, 2025
alexander-shaposhnikov
approved these changes
Apr 14, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/14518 Here is the relevant piece of the build log for the reference |
var-const
pushed a commit
to ldionne/llvm-project
that referenced
this pull request
Apr 17, 2025
…134398) We have AST matchers for fixed point float numbers since commits 789215d and ff91206. However in those commits the unit tests were not added. Amending the test suit by adding missing tests. Co-authored-by: Vladislav Aranov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have AST matchers for fixed point float numbers since commits 789215d and
ff91206. However in those commits the unit tests were not added. Amending the test suit by adding missing tests.