[flang] Add runtime and lowering implementation for extended intrinsic PUTENV #134412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: flang-rt/include/flang-rt/runtime/environment.h modified: flang-rt/lib/runtime/environment.cpp
modified: flang-rt/include/flang-rt/runtime/environment.h modified: flang-rt/lib/runtime/environment.cpp
modified: flang-rt/lib/runtime/command.cpp modified: flang-rt/lib/runtime/environment.cpp modified: flang/include/flang/Optimizer/Builder/IntrinsicCall.h modified: flang/include/flang/Optimizer/Builder/Runtime/Command.h modified: flang/include/flang/Runtime/command.h modified: flang/lib/Evaluate/intrinsics.cpp modified: flang/lib/Optimizer/Builder/IntrinsicCall.cpp modified: flang/lib/Optimizer/Builder/Runtime/Command.cpp
modified: flang-rt/lib/runtime/command.cpp modified: flang-rt/lib/runtime/environment.cpp modified: flang/include/flang/Optimizer/Builder/IntrinsicCall.h modified: flang/lib/Optimizer/Builder/IntrinsicCall.cpp
modified: flang/docs/Intrinsics.md
new file: test/Lower/Intrinsics/putenv-func.f90 new file: test/Lower/Intrinsics/putenv-sub.f90 new file: test/Semantics/putenv.f90
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
eugeneepshteyn
commented
Apr 4, 2025
| std::int32_t UnsetEnv( | ||
| const char *name, std::size_t name_length, | ||
| const Terminator &terminator); | ||
|
|
There was a problem hiding this comment.
SetEnv() and UnsetEnv() could be used by the rest flang-rt, if necessary
|
Fix formatting and ship it; thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement extended intrinsic PUTENV, both function and subroutine forms. Add PUTENV documentation to flang/docs/Intrinsics.md. Add functional and semantic unit tests.