Skip to content

[JITLink][NFC] Guard functions used only for debug for XCOFFLinkGraphBuilder #134413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

[JITLink][NFC] Guard functions used only for debug for XCOFFLinkGraphBuilder #134413

merged 1 commit into from
Apr 7, 2025

Conversation

mustartt
Copy link
Member

@mustartt mustartt commented Apr 4, 2025

2 of the functions in XCOFFGraphBuilder are only for debugging. So we need to guard it to avoid warnings.

@mustartt mustartt requested a review from mikaelholmen April 4, 2025 16:41
@mustartt mustartt mentioned this pull request Apr 4, 2025
Merged
mikaelholmen
mikaelholmen approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@mikaelholmen mikaelholmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mustartt mustartt merged commit 600eeed into llvm:main Apr 7, 2025
12 checks passed
@mustartt mustartt deleted the jitlink-remove-unused-func branch April 7, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelholmen mikaelholmen mikaelholmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mustartt @mikaelholmen