[lldb] Make RegisterContextThreadMemory thread safe
#134469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UpdateRegisterContext method can be called from multiple threads.
|
@llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) ChangesThe UpdateRegisterContext method can be called from multiple threads. Full diff: https://github.com/llvm/llvm-project/pull/134469.diff 2 Files Affected:
diff --git a/lldb/source/Plugins/Process/Utility/RegisterContextThreadMemory.cpp b/lldb/source/Plugins/Process/Utility/RegisterContextThreadMemory.cpp
index 75438550ce914..29927e3b5e4ed 100644
--- a/lldb/source/Plugins/Process/Utility/RegisterContextThreadMemory.cpp
+++ b/lldb/source/Plugins/Process/Utility/RegisterContextThreadMemory.cpp
@@ -25,6 +25,8 @@ RegisterContextThreadMemory::RegisterContextThreadMemory(
RegisterContextThreadMemory::~RegisterContextThreadMemory() = default;
void RegisterContextThreadMemory::UpdateRegisterContext() {
+ std::lock_guard<std::mutex> lock(m_update_register_ctx_lock);
+
ThreadSP thread_sp(m_thread_wp.lock());
if (thread_sp) {
ProcessSP process_sp(thread_sp->GetProcess());
diff --git a/lldb/source/Plugins/Process/Utility/RegisterContextThreadMemory.h b/lldb/source/Plugins/Process/Utility/RegisterContextThreadMemory.h
index 23f675508cf38..1df32bbc1f057 100644
--- a/lldb/source/Plugins/Process/Utility/RegisterContextThreadMemory.h
+++ b/lldb/source/Plugins/Process/Utility/RegisterContextThreadMemory.h
@@ -99,6 +99,8 @@ class RegisterContextThreadMemory : public lldb_private::RegisterContext {
RegisterContextThreadMemory(const RegisterContextThreadMemory &) = delete;
const RegisterContextThreadMemory &
operator=(const RegisterContextThreadMemory &) = delete;
+
+ std::mutex m_update_register_ctx_lock;
};
} // namespace lldb_private
|
felipepiovezan
added a commit
to felipepiovezan/llvm-project
that referenced
this pull request
Apr 5, 2025
The UpdateRegisterContext method can be called from multiple threads. (cherry picked from commit 6272e1f)
felipepiovezan
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Apr 5, 2025
…ry-pick [cherry-pick][lldb] Make `RegisterContextThreadMemory` thread safe (llvm#134469)
felipepiovezan
added a commit
to felipepiovezan/llvm-project
that referenced
this pull request
Apr 7, 2025
The UpdateRegisterContext method can be called from multiple threads. (cherry picked from commit 6272e1f)
adrian-prantl
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Apr 8, 2025
…dsafe_6.2 [lldb] Make `RegisterContextThreadMemory` thread safe (llvm#134469)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UpdateRegisterContext method can be called from multiple threads.