[LLVM][Demangle] Fix MS Demangler to be stricter about wide string literals #134483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terals Static analysis detected that Demangler::demangleStringLiteral had a potential overflow if not checking StringByteSize properly. Added check to ensure that for wide string it is always even and that there were the byte count did not mismatch the actual size of the literal. Fixes: llvm#129970
Fznamznon
reviewed
Apr 7, 2025
llvm/docs/ReleaseNotes.md
Outdated
| @@ -70,6 +70,8 @@ Changes to LLVM infrastructure | |||
|
|
|||
| * Removed support for target intrinsics being defined in the target directories | |||
| themselves (i.e., the `TargetIntrinsicInfo` class). | |||
| * Fix Microsoft demanling of string literals to be stricter | |||
There was a problem hiding this comment.
Suggested change
| * Fix Microsoft demanling of string literals to be stricter | |
| * Fix Microsoft demangling of string literals to be stricter |
AaronBallman
approved these changes
Apr 7, 2025
llvm/docs/ReleaseNotes.md
Outdated
| @@ -70,6 +70,8 @@ Changes to LLVM infrastructure | |||
|
|
|||
| * Removed support for target intrinsics being defined in the target directories | |||
| themselves (i.e., the `TargetIntrinsicInfo` class). | |||
| * Fix Microsoft demanling of string literals to be stricter | |||
| ([Fixes 129970](https://github.com/llvm/llvm-project/issues/129970)) | |||
There was a problem hiding this comment.
Suggested change
| ([Fixes 129970](https://github.com/llvm/llvm-project/issues/129970)) | |
| (#GH129970) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static analysis detected that Demangler::demangleStringLiteral had a potential overflow if not checking StringByteSize properly.
Added check to ensure that for wide string it is always even and that there were the byte count did not mismatch the actual size of the literal.
Fixes: #129970