Skip to content

[NFC][LLVM] Change initialize<PassName>PassOnce to return void #134500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

jurahul
Copy link
Contributor

@jurahul jurahul commented Apr 5, 2025

  • The return value of these functions (called using llvm::call_once) is never used, so make these functions return void.

…void

- The return value of these functions (called using `llvm::call_once`)
  is never used, so make these functions return void.
@jurahul jurahul force-pushed the nfc_pass_init_void branch from 9d95d8c to 032f6a0 Compare April 6, 2025 17:29
@jurahul jurahul marked this pull request as ready for review April 7, 2025 15:53
@jurahul jurahul requested review from bogner and shiltian April 7, 2025 15:54
Copy link
Contributor

@shiltian shiltian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jurahul jurahul merged commit bb1f32d into llvm:main Apr 8, 2025
13 checks passed
@jurahul jurahul deleted the nfc_pass_init_void branch April 8, 2025 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants