[IR] Deprecate PointerType::get/getUnqual pointee type overload #134517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecates the methods and schedules them for removal in the future as the overloads taking LLVMContext are preferred, as the pointee type has no meaning in opaque pointers. Part of #123569
|
@llvm/pr-subscribers-llvm-ir Author: Mats Jun Larsen (junlarsen) ChangesDeprecates the methods and schedules them for removal in the future as Part of #123569 Full diff: https://github.com/llvm/llvm-project/pull/134517.diff 1 Files Affected:
diff --git a/llvm/include/llvm/IR/DerivedTypes.h b/llvm/include/llvm/IR/DerivedTypes.h
index 60606d34c32c3..cc6230287bfe4 100644
--- a/llvm/include/llvm/IR/DerivedTypes.h
+++ b/llvm/include/llvm/IR/DerivedTypes.h
@@ -685,6 +685,9 @@ class PointerType : public Type {
/// This constructs a pointer to an object of the specified type in a numbered
/// address space.
+ LLVM_DEPRECATED("PointerType::get with pointee type is pending removal. Use "
+ "Context overload.",
+ "PointerType::get(LLVMContext, AS)")
static PointerType *get(Type *ElementType, unsigned AddressSpace);
/// This constructs an opaque pointer to an object in a numbered address
/// space.
@@ -692,6 +695,9 @@ class PointerType : public Type {
/// This constructs a pointer to an object of the specified type in the
/// default address space (address space zero).
+ LLVM_DEPRECATED("PointerType::getUnqual with pointee type is pending "
+ "removal. Use Context overload.",
+ "PointerType::getUnqual(LLVMCOntext)")
static PointerType *getUnqual(Type *ElementType) {
return PointerType::get(ElementType, 0);
}
|
nikic
reviewed
Apr 6, 2025
llvm/include/llvm/IR/DerivedTypes.h
Outdated
| @@ -685,13 +685,19 @@ class PointerType : public Type { | |||
|
|
|||
| /// This constructs a pointer to an object of the specified type in a numbered | |||
| /// address space. | |||
| LLVM_DEPRECATED("PointerType::get with pointee type is pending removal. Use " | |||
| "Context overload.", | |||
| "PointerType::get(LLVMContext, AS)") | |||
There was a problem hiding this comment.
Please use [[deprecated]] instead. Only use LLVM_DEPRECATED if you can actually provide a working fixit, which you can't do here.
There was a problem hiding this comment.
Thanks for the heads up! Taken care of in b3c03d6
junlarsen
deleted the
users/junlarsen/_ir_deprecate_pointertype_get_getunqual_pointee_type_overload
branch
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/134/builds/16395 Here is the relevant piece of the build log for the reference |
RKSimon
reviewed
Apr 7, 2025
| static PointerType *get(Type *ElementType, unsigned AddressSpace); | ||
| /// This constructs an opaque pointer to an object in a numbered address | ||
| /// space. | ||
| static PointerType *get(LLVMContext &C, unsigned AddressSpace); | ||
|
|
||
| /// This constructs a pointer to an object of the specified type in the | ||
| /// default address space (address space zero). | ||
| [[deprecated("PointerType::getUnqual with pointee type is pending removal. " | ||
| "Use Context overload.")]] | ||
| static PointerType *getUnqual(Type *ElementType) { | ||
| return PointerType::get(ElementType, 0); |
There was a problem hiding this comment.
@junlarsen MSVC is warning because this is calling the now deprecated llvm.PointerType.get() variant - would it be possible for you to update this to call the LLVMContext variant directly to silence the warning and allow us to re-enable Werror builds please?
junlarsen
added a commit
that referenced
this pull request
Apr 7, 2025
kuhar
added a commit
to iree-org/iree
that referenced
this pull request
Apr 8, 2025
The major changes come from the following PRs: * llvm/llvm-project#131226 * llvm/llvm-project#134264 * llvm/llvm-project#134169 * llvm/llvm-project#134517 --------- Signed-off-by: MaheshRavishankar <[email protected]> Signed-off-by: Jakub Kuderski <[email protected]> Co-authored-by: MaheshRavishankar <[email protected]>
qiaojbao
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Apr 29, 2025
Local branch origin/amd-gfx b969d46 Merged main:94821ce45fe9 into origin/amd-gfx:6bc8f8a713b9 Remote branch main 146ad71 [IR] Deprecate PointerType::get/getUnqual pointee type overload (llvm#134517)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates the methods and schedules them for removal in the future as
the overloads taking LLVMContext are preferred, as the pointee type
has no meaning in opaque pointers.
From what my clangd can tell, there are no usages left in the monorepo
Part of #123569