[Flang][Windows] Fix test_errors.py by enforcing UTF-8 encoding #134625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes UnicodeDecodeError on Windows in test_errors.py. This issue was observed on the flang-arm64-windows-msvc buildbot. Semantics/OpenMP/interop-construct.f90 was crashing due to Python defaulting to the cp1252 codec on Windows I have fixed this by explicitly setting encoding="utf-8" when reading source files and invoking subprocess.run() in test_errors.py flang-arm64-windows-msvc was running on stagging master which resulted in this issue not being fixed earlier. https://lab.llvm.org/staging/#/builders/206
llvmbot
added
flang
|
@llvm/pr-subscribers-flang-semantics Author: Omair Javaid (omjavaid) ChangesThis patch fixes UnicodeDecodeError on Windows in test_errors.py. This issue was observed on the flang-arm64-windows-msvc buildbot. Semantics/OpenMP/interop-construct.f90 was crashing due to Python defaulting to the cp1252 codec on Windows. I have fixed this by explicitly setting encoding="utf-8" when reading source files and invoking subprocess.run() in test_errors.py flang-arm64-windows-msvc was running on stagging master which resulted in this issue not being fixed earlier. Full diff: https://github.com/llvm/llvm-project/pull/134625.diff 1 Files Affected:
diff --git a/flang/test/Semantics/test_errors.py b/flang/test/Semantics/test_errors.py
index 63ff3367edefd..45684764a00e4 100755
--- a/flang/test/Semantics/test_errors.py
+++ b/flang/test/Semantics/test_errors.py
@@ -17,7 +17,7 @@
cm.check_args(sys.argv)
srcdir = cm.set_source(sys.argv[1])
-with open(srcdir, "r") as f:
+with open(srcdir, "r", encoding="utf-8") as f:
src = f.readlines()
actual = ""
expect = ""
@@ -39,6 +39,7 @@
check=True,
universal_newlines=True,
cwd=tmpdir,
+ encoding="utf-8",
)
except subprocess.CalledProcessError as e:
log = e.stderr
|
luporl
approved these changes
Apr 7, 2025
luporl
added a commit
to luporl/llvm-project
that referenced
this pull request
Apr 7, 2025
Some error messages were using a special char for `fi`, in the word `specified`, probably due to a typo. This caused an error on Windows: llvm#134625
luporl
added a commit
that referenced
this pull request
Apr 7, 2025
Some error messages were using a special char for `fi`, in the word `specified`, probably due to a typo. This caused an error on Windows: #134625
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes UnicodeDecodeError on Windows in test_errors.py. This issue was observed on the flang-arm64-windows-msvc buildbot. Semantics/OpenMP/interop-construct.f90 was crashing due to Python defaulting to the cp1252 codec on Windows.
I have fixed this by explicitly setting encoding="utf-8" when reading source files and invoking subprocess.run() in test_errors.py
flang-arm64-windows-msvc was running on stagging master which resulted in this issue not being fixed earlier.
https://lab.llvm.org/staging/#/builders/206