Skip to content

[CI] Reduce false positives in undef checker #134687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Conversation

MacDue
Copy link
Member

@MacDue MacDue commented Apr 7, 2025

Only check for diffs containing "undef" in .ll files, this prevents comments like // We should not have undef values... triggering the undef checker bot.

Only check for diffs containing "undef" in .ll files, this prevents
comments like `// We should not have undef values...` triggering the
undef bot.
Copy link

github-actions bot commented Apr 7, 2025

✅ With the latest revision this PR passed the Python code formatter.

@MacDue MacDue changed the title [CI] Reduce false positives in UndefGetFormatHelper [CI] Reduce false positives in undef checker Apr 7, 2025
Copy link
Member

@nunoplopes nunoplopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MacDue MacDue merged commit e1fc118 into llvm:main Apr 8, 2025
9 of 11 checks passed
@MacDue MacDue deleted the undef_tweak branch April 8, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants