Skip to content

Move CodeGen cuda.h to Inputs from include #134706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

calewis
Copy link
Contributor

@calewis calewis commented Apr 7, 2025

Mirrors the behavior of CodeGenCUDA directory and the location of other .h files in CodeGen.

Copy link

github-actions bot commented Apr 7, 2025

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Apr 7, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 7, 2025

@llvm/pr-subscribers-clang

Author: Drew Lewis (calewis)

Changes

Mirrors the behavior of CodeGenCUDA directory and the location of other .h files in CodeGen.


Full diff: https://github.com/llvm/llvm-project/pull/134706.diff

2 Files Affected:

  • (renamed) clang/test/CodeGen/Inputs/cuda.h ()
  • (modified) clang/test/CodeGen/nvptx-surface.cu (+1-1)
diff --git a/clang/test/CodeGen/include/cuda.h b/clang/test/CodeGen/Inputs/cuda.h
similarity index 100%
rename from clang/test/CodeGen/include/cuda.h
rename to clang/test/CodeGen/Inputs/cuda.h
diff --git a/clang/test/CodeGen/nvptx-surface.cu b/clang/test/CodeGen/nvptx-surface.cu
index cf1fe76893a17..56995f2c0da80 100644
--- a/clang/test/CodeGen/nvptx-surface.cu
+++ b/clang/test/CodeGen/nvptx-surface.cu
@@ -1,6 +1,6 @@
 // RUN: %clang_cc1 -triple nvptx-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s
 // RUN: %clang_cc1 -triple nvptx64-unknown-unknown -fcuda-is-device -O3 -o - %s -emit-llvm | FileCheck %s
-#include "include/cuda.h"
+#include "Inputs/cuda.h"
 
 #include "__clang_cuda_texture_intrinsics.h"
 

@pranavk pranavk requested a review from Artem-B April 7, 2025 19:21
@pranavk pranavk merged commit 27c099b into llvm:main Apr 7, 2025
5 of 7 checks passed
Copy link

github-actions bot commented Apr 7, 2025

@calewis Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@Artem-B
Copy link
Member

Artem-B commented Apr 7, 2025

Fixes test break introduced by #134459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants