[NFCI] Explicitly delete unused copy constructor and assign copy for VPInterleavedAccessInfo #134755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VPInterleavedAccessInfo has a defined destructor freeing memory, but no explicitly defined copy constructor or copy assignment op. These are not used, so this patch marks them as deleted to avoid usage of the implicitly defined implementations.
|
@llvm/pr-subscribers-llvm-transforms @llvm/pr-subscribers-vectorizers Author: None (calebwat) ChangesVPInterleavedAccessInfo has a defined destructor freeing memory, but no explicitly defined copy constructor or copy assignment op. These are not used, so this patch marks them as deleted to avoid usage of the implicitly defined implementations. Full diff: https://github.com/llvm/llvm-project/pull/134755.diff 1 Files Affected:
diff --git a/llvm/lib/Transforms/Vectorize/VPlanSLP.h b/llvm/lib/Transforms/Vectorize/VPlanSLP.h
index 93f04e6e30a6f..7f123689170ad 100644
--- a/llvm/lib/Transforms/Vectorize/VPlanSLP.h
+++ b/llvm/lib/Transforms/Vectorize/VPlanSLP.h
@@ -48,6 +48,8 @@ class VPInterleavedAccessInfo {
public:
VPInterleavedAccessInfo(VPlan &Plan, InterleavedAccessInfo &IAI);
+ VPInterleavedAccessInfo(const VPInterleavedAccessInfo &) = delete;
+ VPInterleavedAccessInfo &operator=(const VPInterleavedAccessInfo &) = delete;
~VPInterleavedAccessInfo() {
// Avoid releasing a pointer twice.
|
fhahn
approved these changes
Apr 8, 2025
|
Ping for merge, if all looks good. |
var-const
pushed a commit
to ldionne/llvm-project
that referenced
this pull request
Apr 17, 2025
…VPInterleavedAccessInfo (llvm#134755) VPInterleavedAccessInfo has a defined destructor freeing memory, but no explicitly defined copy constructor or copy assignment op. These are not used, so this patch marks them as deleted to avoid usage of the implicitly defined implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VPInterleavedAccessInfo has a defined destructor freeing memory, but no explicitly defined copy constructor or copy assignment op. These are not used, so this patch marks them as deleted to avoid usage of the implicitly defined implementations.