Skip to content

[MLIR][Fix] Fix missing dep in AMDGPUDialect. #134862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

lialan
Copy link
Member

@lialan lialan commented Apr 8, 2025

Issue introduced in #133498

@llvmbot
Copy link
Member

llvmbot commented Apr 8, 2025

@llvm/pr-subscribers-mlir-amdgpu

@llvm/pr-subscribers-mlir-gpu

Author: Alan Li (lialan)

Changes

Issue introduced in #133498


Full diff: https://github.com/llvm/llvm-project/pull/134862.diff

1 Files Affected:

  • (modified) mlir/lib/Dialect/AMDGPU/IR/CMakeLists.txt (+1)
diff --git a/mlir/lib/Dialect/AMDGPU/IR/CMakeLists.txt b/mlir/lib/Dialect/AMDGPU/IR/CMakeLists.txt
index 78d78cf48a747..2a019954c8356 100644
--- a/mlir/lib/Dialect/AMDGPU/IR/CMakeLists.txt
+++ b/mlir/lib/Dialect/AMDGPU/IR/CMakeLists.txt
@@ -16,4 +16,5 @@ add_mlir_dialect_library(MLIRAMDGPUDialect
   MLIRGPUDialect
   MLIRIR
   MLIRSideEffectInterfaces
+  MLIRMemRefUtils
   )

@lialan lialan requested a review from kuhar April 8, 2025 14:36
Copy link
Contributor

@skc7 skc7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lialan lialan merged commit b5045ae into llvm:main Apr 8, 2025
14 of 15 checks passed
@jplehr
Copy link
Contributor

jplehr commented Apr 8, 2025

Thank you for fix.

tonykuttai pushed a commit to tonykuttai/llvm-project that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants