[flang] Implement external routine usage of hostnm() #134900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: flang-rt/lib/runtime/extensions.cpp
modified: flang-rt/lib/runtime/extensions.cpp modified: flang/include/flang/Runtime/extensions.h
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
klausler
reviewed
Apr 8, 2025
flang-rt/lib/runtime/extensions.cpp
Outdated
| @@ -264,6 +264,43 @@ int RTNAME(Chdir)(const char *name) { | |||
| #endif | |||
| } | |||
|
|
|||
| int FORTRAN_PROCEDURE_NAME(hostnm)(char *hn, int length) { | |||
|
|
|||
There was a problem hiding this comment.
This would be a lot easier to read if it wasn't so needlessly stretched out vertically by all these blank lines.
There was a problem hiding this comment.
Removed some blank lines.
klausler
reviewed
Apr 8, 2025
flang-rt/lib/runtime/extensions.cpp
Outdated
| if (status == 0) { | ||
| // Find zero terminator and fill the string from the | ||
| // zero terminator to the end with spaces | ||
| char *str_end = hn + length; |
There was a problem hiding this comment.
Always use braced initialization in the runtime and other modern C++ directories, please.
klausler
approved these changes
Apr 15, 2025
var-const
pushed a commit
to ldionne/llvm-project
that referenced
this pull request
Apr 17, 2025
Previously, `hostnm` extended intrinsic was implemented as proper intrinsic. Since then we found out that some applications use `hostnm` as external routine via `external hostnm`. This prevents `hostnm` from being recognized as an intrinsic. This PR implements `hostnm` as external routine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
hostnmextended intrinsic was implemented as proper intrinsic. Since then we found out that some applications usehostnmas external routine viaexternal hostnm. This preventshostnmfrom being recognized as an intrinsic. This PR implementshostnmas external routine.