[Clang] Add non static data member initializer for BindingDecl member Decomp #134969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Decomp Static analysis flagged BindingDecl Decomp member as not being initialized during construction or by any other member function. Fix is add a default initializer for it like the other member Binding.
shafik
added
the
clang:frontend
|
@llvm/pr-subscribers-clang Author: Shafik Yaghmour (shafik) ChangesStatic analysis flagged BindingDecl Decomp member as not being initialized during construction or by any other member function. Fix is add a default initializer for it like the other member Binding. Full diff: https://github.com/llvm/llvm-project/pull/134969.diff 1 Files Affected:
diff --git a/clang/include/clang/AST/DeclCXX.h b/clang/include/clang/AST/DeclCXX.h
index 56cec07ec0293..f0e25c4105f87 100644
--- a/clang/include/clang/AST/DeclCXX.h
+++ b/clang/include/clang/AST/DeclCXX.h
@@ -4166,7 +4166,7 @@ class StaticAssertDecl : public Decl {
/// DecompositionDecl of type 'int (&)[3]'.
class BindingDecl : public ValueDecl {
/// The declaration that this binding binds to part of.
- ValueDecl *Decomp;
+ ValueDecl *Decomp = nullptr;
/// The binding represented by this declaration. References to this
/// declaration are effectively equivalent to this expression (except
/// that it is only evaluated once at the point of declaration of the
|
zyn0217
approved these changes
Apr 9, 2025
AllinLeeYL
pushed a commit
to AllinLeeYL/llvm-project
that referenced
this pull request
Apr 10, 2025
… Decomp (llvm#134969) Static analysis flagged BindingDecl Decomp member as not being initialized during construction or by any other member function. Fix is add a default initializer for it like the other member Binding.
var-const
pushed a commit
to ldionne/llvm-project
that referenced
this pull request
Apr 17, 2025
… Decomp (llvm#134969) Static analysis flagged BindingDecl Decomp member as not being initialized during construction or by any other member function. Fix is add a default initializer for it like the other member Binding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static analysis flagged BindingDecl Decomp member as not being initialized during construction or by any other member function.
Fix is add a default initializer for it like the other member Binding.