[MSan] Update type for MsanMetadataPtrForLoadN and MsanMetadataPtrForStoreN #135040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed last parameter type from i64 to IntptrTy to keep it consistent with call in getShadowOriginPtrKernelNoVec
|
@llvm/pr-subscribers-compiler-rt-sanitizer @llvm/pr-subscribers-llvm-transforms Author: None (k-kashapov) ChangesChanged last parameter type for Ping @vitalybuka Full diff: https://github.com/llvm/llvm-project/pull/135040.diff 1 Files Affected:
diff --git a/llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp b/llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
index 0a7a1f2ebbf4c..820ca3eec36cf 100644
--- a/llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
+++ b/llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp
@@ -846,9 +846,9 @@ void MemorySanitizer::createKernelApi(Module &M, const TargetLibraryInfo &TLI) {
}
MsanMetadataPtrForLoadN = getOrInsertMsanMetadataFunction(
- M, "__msan_metadata_ptr_for_load_n", PtrTy, IRB.getInt64Ty());
+ M, "__msan_metadata_ptr_for_load_n", PtrTy, IntptrTy);
MsanMetadataPtrForStoreN = getOrInsertMsanMetadataFunction(
- M, "__msan_metadata_ptr_for_store_n", PtrTy, IRB.getInt64Ty());
+ M, "__msan_metadata_ptr_for_store_n", PtrTy, IntptrTy);
// Functions for poisoning and unpoisoning memory.
MsanPoisonAllocaFn = M.getOrInsertFunction(
|
vitalybuka
approved these changes
Apr 9, 2025
|
@k-kashapov This looks redundant. Probably settings of your local checkout need to be updated.
|
AllinLeeYL
pushed a commit
to AllinLeeYL/llvm-project
that referenced
this pull request
Apr 10, 2025
…StoreN (llvm#135040) Changed last parameter type for `MsanMetadataPtrForLoadN` and `MsanMetadataPtrForStoreN` from `i64` to `IntptrTy` to keep it consistent with call in `getShadowOriginPtrKernelNoVec` Co-authored-by: Kamil Kashapov <[email protected]>
var-const
pushed a commit
to ldionne/llvm-project
that referenced
this pull request
Apr 17, 2025
…StoreN (llvm#135040) Changed last parameter type for `MsanMetadataPtrForLoadN` and `MsanMetadataPtrForStoreN` from `i64` to `IntptrTy` to keep it consistent with call in `getShadowOriginPtrKernelNoVec` Co-authored-by: Kamil Kashapov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed last parameter type for
MsanMetadataPtrForLoadNandMsanMetadataPtrForStoreNfromi64toIntptrTyto keep it consistent with call ingetShadowOriginPtrKernelNoVec