Skip to content

Revert "[llc] Add -M for InstPrinter options" #135070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

thurstond
Copy link
Contributor

@thurstond thurstond commented Apr 9, 2025

Reverts #121078

Reason: buildbot breakage (https://lab.llvm.org/buildbot/#/builders/55/builds/9607), reported earlier in #121078 (comment)

******************** TEST 'LLVM :: tools/llc/instprinter-options.ll' FAILED ********************
Exit Code: 1
Command Output (stderr):
--
not /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/llc -mtriple=x86_64 < /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/test/tools/llc/instprinter-options.ll -M invalid 2>&1 | /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/FileCheck /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/test/tools/llc/instprinter-options.ll --implicit-check-not=error: # RUN: at line 2
+ not /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/llc -mtriple=x86_64 -M invalid
+ /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/FileCheck /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/test/tools/llc/instprinter-options.ll --implicit-check-not=error:
command line:1:22: error: IMPLICIT-CHECK-NOT: excluded string found in input
-implicit-check-not='error:'
                     ^
<stdin>:3:1: note: found here
error: Aborted
^~~~~~
Input file: <stdin>
Check file: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm-project/llvm/test/tools/llc/instprinter-options.ll
-dump-input=help explains the following input dump.
Input was:
<<<<<<
          1: /home/b/sanitizer-aarch64-linux-bootstrap-hwasan/build/llvm_build_hwasan/bin/llc: error: invalid InstPrinter option 'invalid' 
          2: libc++abi: Pure virtual function called! 
          3: error: Aborted 
not:imp1     !~~~~~          error: no match expected
>>>>>>

@thurstond thurstond requested a review from MaskRay April 9, 2025 19:08
@MaskRay
Copy link
Member

MaskRay commented Apr 10, 2025

Thanks!
Should be fixed by 2b8cc65

@thurstond
Copy link
Contributor Author

Thanks! Should be fixed by 2b8cc65

Awesome, thanks! :-)

@thurstond thurstond closed this Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants