[MLIR][NFC] Expose computeProduct function.

[lialan]

Make it non-static, as its functionality is quite generic.

[Copilot]

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

mlir/lib/Dialect/Affine/IR/AffineOps.cpp:5084

• Since computeProduct is now exposed for broader use, please ensure that test cases cover scenarios for both nullptr checks and dynamic non-constant term handling to maintain robust behavior.

OpFoldResult computeProduct(Location loc, OpBuilder &builder,

[llvmbot]

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-affine

Author: Alan Li (lialan)

Changes

Make it non-static, as its functionality is quite generic.

---

Full diff: https://github.com/llvm/llvm-project/pull/135192.diff

2 Files Affected:

• (modified) mlir/include/mlir/Dialect/Affine/IR/AffineOps.h (+5)
• (modified) mlir/lib/Dialect/Affine/IR/AffineOps.cpp (+2-4)

diff --git a/mlir/include/mlir/Dialect/Affine/IR/AffineOps.h b/mlir/include/mlir/Dialect/Affine/IR/AffineOps.h
index bbf38f2293448..6fdb72c370e6d 100644
--- a/mlir/include/mlir/Dialect/Affine/IR/AffineOps.h
+++ b/mlir/include/mlir/Dialect/Affine/IR/AffineOps.h
@@ -53,6 +53,11 @@ Region *getAffineScope(Operation *op);
 /// analysis scope.
 Region *getAffineAnalysisScope(Operation *op);
 
+/// Return the product of `terms`, creating an `affine.apply` if any of them are
+/// non-constant values. If any of `terms` is `nullptr`, return `nullptr`.
+OpFoldResult computeProduct(Location loc, OpBuilder &builder,
+                            ArrayRef<OpFoldResult> terms);
+
 /// AffineDmaStartOp starts a non-blocking DMA operation that transfers data
 /// from a source memref to a destination memref. The source and destination
 /// memref need not be of the same dimensionality, but need to have the same
diff --git a/mlir/lib/Dialect/Affine/IR/AffineOps.cpp b/mlir/lib/Dialect/Affine/IR/AffineOps.cpp
index 9c5b9e82cd5e0..aa49c49062c76 100644
--- a/mlir/lib/Dialect/Affine/IR/AffineOps.cpp
+++ b/mlir/lib/Dialect/Affine/IR/AffineOps.cpp
@@ -5081,10 +5081,8 @@ struct DropLinearizeUnitComponentsIfDisjointOrZero final
   }
 };
 
-/// Return the product of `terms`, creating an `affine.apply` if any of them are
-/// non-constant values. If any of `terms` is `nullptr`, return `nullptr`.
-static OpFoldResult computeProduct(Location loc, OpBuilder &builder,
-                                   ArrayRef<OpFoldResult> terms) {
+OpFoldResult computeProduct(Location loc, OpBuilder &builder,
+                            ArrayRef<OpFoldResult> terms) {
   int64_t nDynamic = 0;
   SmallVector<Value> dynamicPart;
   AffineExpr result = builder.getAffineConstantExpr(1);

[krzysz00]

Lgtm