-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[DirectX] XFAIL test failing because of debuginfo changes #135279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@llvm/pr-subscribers-backend-directx Author: Farzon Lotfi (farzonl) ChangesFor more context see https://discourse.llvm.org/t/psa-ir-output-changing-from-debug-intrinsics-to-debug-records/79578 This change: 6a45fce LLVM is transitioning off of the llvm.dbg.value debug intrinsic in favor of the `#dbg_declare(..) format. see https://github.com/llvm/llvm-project/pull/133917/files dxil-dis does not understand the new format and so work needs to be planned out to support this transition in https://github.com/microsoft/DirectXShaderCompiler For now the fix is to XFAIL this test to unblock the pipeline. Full diff: https://github.com/llvm/llvm-project/pull/135279.diff 1 Files Affected:
diff --git a/llvm/test/tools/dxil-dis/debug-info.ll b/llvm/test/tools/dxil-dis/debug-info.ll
index c042b60ce2396..1a615bd19d38f 100644
--- a/llvm/test/tools/dxil-dis/debug-info.ll
+++ b/llvm/test/tools/dxil-dis/debug-info.ll
@@ -1,4 +1,7 @@
; RUN: llc --filetype=obj %s -o - -experimental-debuginfo-iterators=false | dxil-dis -o - | FileCheck %s
+; Note: LLVM has soft disabled experimental-debuginfo-iterators in commit 6a45fce
+// XFAIL: *
+
target triple = "dxil-unknown-shadermodel6.7-library"
target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
|
For more context see https://discourse.llvm.org/t/psa-ir-output-changing-from-debug-intrinsics-to-debug-records/79578 This change: llvm@6a45fce broke this test: https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/dxil-dis/debug-info.ll in our pipeline: https://github.com/llvm/llvm-project/actions/workflows/hlsl-matrix.yaml LLVM is transitioning off of the llvm.dbg.value debug intrinsic in favor of the `#dbg_declare(..) format. see https://github.com/llvm/llvm-project/pull/133917/files dxil-dis does not understand the new format and so work needs to be planned out to support this transition in https://github.com/microsoft/DirectXShaderCompiler For now the fix is to XFAIL this test to unblock the pipeline.
a3f8c37
to
a1c104e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an issue tracking fixing this?
This is the ticket to track: |
For more context see https://discourse.llvm.org/t/psa-ir-output-changing-from-debug-intrinsics-to-debug-records/79578 This change: llvm@6a45fce broke this test: https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/dxil-dis/debug-info.ll in our pipeline: https://github.com/llvm/llvm-project/actions/workflows/hlsl-matrix.yaml LLVM is transitioning off of the llvm.dbg.value debug intrinsic in favor of the `#dbg_declare(..) format. see https://github.com/llvm/llvm-project/pull/133917/files dxil-dis does not understand the new format and so work needs to be planned out to support this transition in https://github.com/microsoft/DirectXShaderCompiler For now the fix is to XFAIL this test to unblock the pipeline.
For more context see https://discourse.llvm.org/t/psa-ir-output-changing-from-debug-intrinsics-to-debug-records/79578
This change: 6a45fce
broke this test: https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/dxil-dis/debug-info.ll
in our pipeline: https://github.com/llvm/llvm-project/actions/workflows/hlsl-matrix.yaml
LLVM is transitioning off of the llvm.dbg.value debug intrinsic in favor of the `#dbg_declare(..) format. see https://github.com/llvm/llvm-project/pull/133917/files
dxil-dis does not understand the new format and so work needs to be planned out to support this transition
For now the fix is to XFAIL this test to unblock the pipeline.