Skip to content

[DirectX] XFAIL test failing because of debuginfo changes #135279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

farzonl
Copy link
Member

@farzonl farzonl commented Apr 10, 2025

For more context see https://discourse.llvm.org/t/psa-ir-output-changing-from-debug-intrinsics-to-debug-records/79578

This change: 6a45fce
broke this test: https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/dxil-dis/debug-info.ll
in our pipeline: https://github.com/llvm/llvm-project/actions/workflows/hlsl-matrix.yaml

LLVM is transitioning off of the llvm.dbg.value debug intrinsic in favor of the `#dbg_declare(..) format. see https://github.com/llvm/llvm-project/pull/133917/files

dxil-dis does not understand the new format and so work needs to be planned out to support this transition

For now the fix is to XFAIL this test to unblock the pipeline.

@llvmbot
Copy link
Member

llvmbot commented Apr 10, 2025

@llvm/pr-subscribers-backend-directx

Author: Farzon Lotfi (farzonl)

Changes

For more context see https://discourse.llvm.org/t/psa-ir-output-changing-from-debug-intrinsics-to-debug-records/79578

This change: 6a45fce
broke this test: https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/dxil-dis/debug-info.ll
in our pipeline: https://github.com/llvm/llvm-project/actions/workflows/hlsl-matrix.yaml

LLVM is transitioning off of the llvm.dbg.value debug intrinsic in favor of the `#dbg_declare(..) format. see https://github.com/llvm/llvm-project/pull/133917/files

dxil-dis does not understand the new format and so work needs to be planned out to support this transition in https://github.com/microsoft/DirectXShaderCompiler

For now the fix is to XFAIL this test to unblock the pipeline.


Full diff: https://github.com/llvm/llvm-project/pull/135279.diff

1 Files Affected:

  • (modified) llvm/test/tools/dxil-dis/debug-info.ll (+3)
diff --git a/llvm/test/tools/dxil-dis/debug-info.ll b/llvm/test/tools/dxil-dis/debug-info.ll
index c042b60ce2396..1a615bd19d38f 100644
--- a/llvm/test/tools/dxil-dis/debug-info.ll
+++ b/llvm/test/tools/dxil-dis/debug-info.ll
@@ -1,4 +1,7 @@
 ; RUN: llc --filetype=obj %s -o  - -experimental-debuginfo-iterators=false | dxil-dis -o - | FileCheck %s
+; Note: LLVM has soft disabled experimental-debuginfo-iterators in commit 6a45fce
+// XFAIL: *
+
 target triple = "dxil-unknown-shadermodel6.7-library"
 target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128"
 

@farzonl farzonl self-assigned this Apr 10, 2025
For more context see https://discourse.llvm.org/t/psa-ir-output-changing-from-debug-intrinsics-to-debug-records/79578

This change: llvm@6a45fce
broke this test: https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/dxil-dis/debug-info.ll
in our pipeline: https://github.com/llvm/llvm-project/actions/workflows/hlsl-matrix.yaml

LLVM is transitioning off of the llvm.dbg.value debug intrinsic in
favor of the `#dbg_declare(..) format. see https://github.com/llvm/llvm-project/pull/133917/files

dxil-dis does not understand the new format and so work needs to be
planned out to support this transition in https://github.com/microsoft/DirectXShaderCompiler

For now the fix is to XFAIL this test to unblock the pipeline.
@farzonl farzonl force-pushed the pipelinefix/debug-info-failure branch from a3f8c37 to a1c104e Compare April 10, 2025 23:35
@farzonl farzonl moved this to Needs Review in HLSL Support Apr 10, 2025
Copy link
Contributor

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue tracking fixing this?

@farzonl
Copy link
Member Author

farzonl commented Apr 11, 2025

Is there an issue tracking fixing this?

This is the ticket to track:
#135395

@farzonl farzonl merged commit 438f984 into llvm:main Apr 11, 2025
11 checks passed
@farzonl farzonl moved this from Needs Review to Closed in HLSL Support Apr 16, 2025
var-const pushed a commit to ldionne/llvm-project that referenced this pull request Apr 17, 2025
For more context see
https://discourse.llvm.org/t/psa-ir-output-changing-from-debug-intrinsics-to-debug-records/79578

This change:
llvm@6a45fce
broke this test:
https://github.com/llvm/llvm-project/blob/main/llvm/test/tools/dxil-dis/debug-info.ll
in our pipeline:
https://github.com/llvm/llvm-project/actions/workflows/hlsl-matrix.yaml

LLVM is transitioning off of the llvm.dbg.value debug intrinsic in favor
of the `#dbg_declare(..) format. see
https://github.com/llvm/llvm-project/pull/133917/files

dxil-dis does not understand the new format and so work needs to be
planned out to support this transition in
https://github.com/microsoft/DirectXShaderCompiler

For now the fix is to XFAIL this test to unblock the pipeline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants