[Bazel] Remove redundant gtest_main from codegen_tests, codegen_globalisel_tests, mi_tests #135316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lisel_tests, mi_tests
HighW4y2H3ll
requested review from
rupprecht,
keith and
aaronmondal
as code owners
|
ping @rupprecht @keith @aaronmondal Could you double check on this? Because there seem to have two |
keith
approved these changes
Apr 16, 2025
|
Thx!! honestly... I'm not too sure how how these tests work with the CMakeLists builds... so just trying to be safe here, and hopefully not breaking things. :p |
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…lisel_tests, mi_tests (llvm#135316) For codegen_tests, codegen_globalisel_tests and mi_tests, they already have their own `main` function defined, so there should be no need to add `gtest_main` dependency for the main function... - codegen_tests: https://github.com/llvm/llvm-project/blob/main/llvm/unittests/CodeGen/TargetOptionsTest.cpp#L73 - codegen_globalisel_tests: https://github.com/llvm/llvm-project/blob/main/llvm/unittests/CodeGen/GlobalISel/PatternMatchTest.cpp#L978 - mi_tests: https://github.com/llvm/llvm-project/blob/main/llvm/unittests/MI/LiveIntervalTest.cpp#L933
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…lisel_tests, mi_tests (llvm#135316) For codegen_tests, codegen_globalisel_tests and mi_tests, they already have their own `main` function defined, so there should be no need to add `gtest_main` dependency for the main function... - codegen_tests: https://github.com/llvm/llvm-project/blob/main/llvm/unittests/CodeGen/TargetOptionsTest.cpp#L73 - codegen_globalisel_tests: https://github.com/llvm/llvm-project/blob/main/llvm/unittests/CodeGen/GlobalISel/PatternMatchTest.cpp#L978 - mi_tests: https://github.com/llvm/llvm-project/blob/main/llvm/unittests/MI/LiveIntervalTest.cpp#L933
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…lisel_tests, mi_tests (llvm#135316) For codegen_tests, codegen_globalisel_tests and mi_tests, they already have their own `main` function defined, so there should be no need to add `gtest_main` dependency for the main function... - codegen_tests: https://github.com/llvm/llvm-project/blob/main/llvm/unittests/CodeGen/TargetOptionsTest.cpp#L73 - codegen_globalisel_tests: https://github.com/llvm/llvm-project/blob/main/llvm/unittests/CodeGen/GlobalISel/PatternMatchTest.cpp#L978 - mi_tests: https://github.com/llvm/llvm-project/blob/main/llvm/unittests/MI/LiveIntervalTest.cpp#L933
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For codegen_tests, codegen_globalisel_tests and mi_tests, they already have their own
mainfunction defined, so there should be no need to addgtest_maindependency for the main function...