[MLIR][CAPI] add C API typedef to fix downstream C API usage #135380
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bangtian Liu <[email protected]>
|
@llvm/pr-subscribers-mlir Author: Bangtian Liu (bangtianliu) ChangesThis PR is after #135253 and #134935 to fix the error reported by #135253 (comment). This PR Adds typedef declarations for I confirm that this fix resolves the reported error based on my testing. Full diff: https://github.com/llvm/llvm-project/pull/135380.diff 1 Files Affected:
diff --git a/mlir/include/mlir-c/Dialect/Linalg.h b/mlir/include/mlir-c/Dialect/Linalg.h
index 838c280903e2e..4f2ee0d434222 100644
--- a/mlir/include/mlir-c/Dialect/Linalg.h
+++ b/mlir/include/mlir-c/Dialect/Linalg.h
@@ -24,19 +24,19 @@ mlirLinalgFillBuiltinNamedOpRegion(MlirOperation mlirOp);
MLIR_CAPI_EXPORTED bool mlirLinalgIsAContractionOp(MlirOperation op);
-struct MlirLinalgContractionDimensions {
+typedef struct MlirLinalgContractionDimensions {
MlirAttribute batch;
MlirAttribute m;
MlirAttribute n;
MlirAttribute k;
-};
+} MlirLinalgContractionDimensions;
MLIR_CAPI_EXPORTED MlirLinalgContractionDimensions
mlirLinalgInferContractionDimensions(MlirOperation op);
MLIR_CAPI_EXPORTED bool mlirLinalgIsAConvolutionOp(MlirOperation op);
-struct MlirLinalgConvolutionDimensions {
+typedef struct MlirLinalgConvolutionDimensions {
MlirAttribute batch;
MlirAttribute outputImage;
MlirAttribute outputChannel;
@@ -45,7 +45,7 @@ struct MlirLinalgConvolutionDimensions {
MlirAttribute depth;
MlirAttribute strides;
MlirAttribute dilations;
-};
+} MlirLinalgConvolutionDimensions;
MLIR_CAPI_EXPORTED MlirLinalgConvolutionDimensions
mlirLinalgInferConvolutionDimensions(MlirOperation op);
|
nikic
changed the title
makslevental
approved these changes
Apr 11, 2025
kuhar
approved these changes
Apr 11, 2025
There was a problem hiding this comment.
LGTM. This seems consistent with how other C sturcts are defined, e.g.:
llvm-project/mlir/include/mlir-c/IR.h
Lines 46 to 49 in 88e15b7
var-const
pushed a commit
to ldionne/llvm-project
that referenced
this pull request
Apr 17, 2025
…5380) This PR is after llvm#135253 and llvm#134935 to fix the error reported by llvm#135253 (comment). This PR Adds typedef declarations for `MlirLinalgContractionDimensions` and `MlirLinalgConvolutionDimensions` in the C API to ensure compatibility with pure C code. I confirm that this fix resolves the reported error based on my testing. Signed-off-by: Bangtian Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is after #135253 and #134935 to fix the error reported by #135253 (comment). This PR Adds typedef declarations for
MlirLinalgContractionDimensionsandMlirLinalgConvolutionDimensionsin the C API to ensure compatibility with pure C code.I confirm that this fix resolves the reported error based on my testing.