[Clang][CodeGen][OpenCL] Add -fno-delete-null-pointer-checks to avoid UB. NFC.

[dtcxzyw]

Needed by #130742.

[llvmbot]

@llvm/pr-subscribers-clang

Author: Yingwei Zheng (dtcxzyw)

Changes

Needed by #130742.

---

Full diff: https://github.com/llvm/llvm-project/pull/135602.diff

3 Files Affected:

• (modified) clang/test/CodeGenOpenCL/spir32_target.cl (+1-1)
• (modified) clang/test/CodeGenOpenCL/spir64_target.cl (+1-1)
• (modified) clang/test/CodeGenOpenCL/spirv_target.cl (+2-2)

diff --git a/clang/test/CodeGenOpenCL/spir32_target.cl b/clang/test/CodeGenOpenCL/spir32_target.cl
index 924b2c12f5537..cccdf3635ea63 100644
--- a/clang/test/CodeGenOpenCL/spir32_target.cl
+++ b/clang/test/CodeGenOpenCL/spir32_target.cl
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 %s -triple "spir-unknown-unknown" -emit-llvm -o - | FileCheck %s
+// RUN: %clang_cc1 %s -triple "spir-unknown-unknown" -fno-delete-null-pointer-checks -emit-llvm -o - | FileCheck %s
 
 // CHECK: target triple = "spir-unknown-unknown"
 
diff --git a/clang/test/CodeGenOpenCL/spir64_target.cl b/clang/test/CodeGenOpenCL/spir64_target.cl
index ba4a66d7158fd..67880f47adb34 100644
--- a/clang/test/CodeGenOpenCL/spir64_target.cl
+++ b/clang/test/CodeGenOpenCL/spir64_target.cl
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 %s -triple "spir64-unknown-unknown" -emit-llvm -o - | FileCheck %s
+// RUN: %clang_cc1 %s -triple "spir64-unknown-unknown" -emit-llvm -fno-delete-null-pointer-checks -o - | FileCheck %s
 
 // CHECK: target triple = "spir64-unknown-unknown"
 
diff --git a/clang/test/CodeGenOpenCL/spirv_target.cl b/clang/test/CodeGenOpenCL/spirv_target.cl
index 2aeed195449a8..f9e92a79d5617 100644
--- a/clang/test/CodeGenOpenCL/spirv_target.cl
+++ b/clang/test/CodeGenOpenCL/spirv_target.cl
@@ -1,5 +1,5 @@
-// RUN: %clang_cc1 %s -triple "spirv32-unknown-unknown" -verify -emit-llvm -o - | FileCheck %s -check-prefix=SPIRV32
-// RUN: %clang_cc1 %s -triple "spirv64-unknown-unknown" -verify -emit-llvm -o - | FileCheck %s -check-prefix=SPIRV64
+// RUN: %clang_cc1 %s -triple "spirv32-unknown-unknown" -fno-delete-null-pointer-checks -verify -emit-llvm -o - | FileCheck %s -check-prefix=SPIRV32
+// RUN: %clang_cc1 %s -triple "spirv64-unknown-unknown" -fno-delete-null-pointer-checks -verify -emit-llvm -o - | FileCheck %s -check-prefix=SPIRV64
 
 // SPIRV32: target triple = "spirv32-unknown-unknown"
 // SPIRV64: target triple = "spirv64-unknown-unknown"

[efriedma-quic]

I don't see any optimization flags here... is this somehow running the optimizer by default?

If it is, this change is fine, I guess.

[dtcxzyw]

The default optimization level for opencl frontend is O2 :)

llvm-project/clang/lib/Frontend/CompilerInvocation.cpp

Lines 717 to 723 in 83344da

	static unsigned getOptimizationLevel(ArgList &Args, InputKind IK,
	DiagnosticsEngine &Diags) {
	unsigned DefaultOpt = 0;
	if ((IK.getLanguage() == Language::OpenCL ||
	IK.getLanguage() == Language::OpenCLCXX) &&
	!Args.hasArg(OPT_cl_opt_disable))
	DefaultOpt = 2;